From: Johan Parin <johanparin@gmail.com>
To: notmuch@notmuchmail.org
Cc: Johan Parin <johan.parin@gmail.com>
Subject: [PATCH] Fix format_headers_sprinter to return all headers
Date: Sat, 9 Nov 2019 18:44:13 +0100 [thread overview]
Message-ID: <20191109174413.97663-1-johan.parin@gmail.com> (raw)
Modify format_headers_sprinter so that it returns all headers in the
sexp, instead of a fixed set of headers.
This is required in order for the elisp variable
`notmuch-message-headers' to work.
See this bug report:
https://notmuchmail.org/pipermail/notmuch/2017/026069.html
---
notmuch-show.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/notmuch-show.c b/notmuch-show.c
index 21792a57..9652ed09 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -205,6 +205,15 @@ format_headers_sprinter (sprinter_t *sp, GMimeMessage *message,
char *recipients_string;
const char *reply_to_string;
void *local = talloc_new (sp);
+ GMimeHeaderList *header_list;
+ GMimeHeader *header;
+ int header_count;
+ /* Headers requiring some special treatment in formatting */
+ const char* special_headers[] = {"Subject", "From", "To", "Cc", "Bcc",
+ "Reply-To", "In-reply-to", "References",
+ "Date"};
+ const int special_header_count = sizeof(special_headers) / sizeof(char *);
+ bool special;
sp->begin_map (sp);
@@ -255,6 +264,24 @@ format_headers_sprinter (sprinter_t *sp, GMimeMessage *message,
sp->string (sp, g_mime_message_get_date_string (sp, message));
}
+ header_list = g_mime_object_get_header_list (GMIME_OBJECT(message));
+ header_count = g_mime_header_list_get_count(header_list);
+
+ for (int i = 0; i < header_count; i++) {
+ header = g_mime_header_list_get_header_at(header_list, i);
+ special = false;
+ for (int k = 0; k < special_header_count; k++)
+ if (!STRNCMP_LITERAL(g_mime_header_get_name(header),
+ special_headers[k])) {
+ special = true;
+ break;
+ }
+ if (special)
+ continue;
+ sp->map_key (sp, g_mime_header_get_name(header));
+ sp->string (sp, g_mime_header_get_value(header));
+ }
+
sp->end (sp);
talloc_free (local);
}
--
2.21.0 (Apple Git-122)
next reply other threads:[~2019-11-09 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 17:44 Johan Parin [this message]
2019-11-09 19:19 ` [PATCH] Fix format_headers_sprinter to return all headers Jani Nikula
2019-11-09 20:30 ` David Bremner
2019-11-10 9:49 ` Jani Nikula
2019-11-09 20:32 ` Johan Parin
2019-11-10 9:46 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191109174413.97663-1-johan.parin@gmail.com \
--to=johanparin@gmail.com \
--cc=johan.parin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).