unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* v4 of legacy-display cleanup
@ 2019-08-29 15:38 Daniel Kahn Gillmor
  2019-08-29 15:38 ` [PATCH v4 1/8] mime-node: split out _mime_node_set_up_part Daniel Kahn Gillmor
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Daniel Kahn Gillmor @ 2019-08-29 15:38 UTC (permalink / raw)
  To: Notmuch Mail

This is the fourth revision of the series that cleans up legacy-display
protected headers parts so that notmuch users only have to look at one
subject line.

version 3 can be found at id:20190625014107.12452-1-dkg@fifthhorseman.net
version 2 can be found at id:20190531075907.17035-1-dkg@fifthhorseman.net
version 1 can be found at id:20190531042825.27774-1-dkg@fifthhorseman.net

----------
Now that notmuch can handle and interpret protected subject lines, it
should also avoid forcing the user to look at "legacy display" parts
that some MUAs (notably enigmail) copies of the protected headers that
are intended to be rendered only by legacy clients -- clients capable
of decryption but which don't understand how to handle protected
headers.
----------

This series addresses the concerns raised by David Bremner on the
mailing list.

The differences from version 3 are:

 * clearer semantics within the patch series, both code and commit
   messages (e.g. indicating that a new return value is temporarily
   unused in patch 5, before using it in subsequent patches)

 * separating out the non-functional change in argument name
   ("payload" to "part") into its own patch (4/8) for clarity

 * using "goto DONE" instead of "break" in patch 6.

 * using INTERNAL_ERROR in patch 5 to catch potential future internal
   misuse of _notmuch_message_crypto_potential_payload.

If we can get this merged, i'll send a subsequent revision of the
series that repairs "mixed-up MIME" mangled messages.

I would appreciate any feedback!

  --dkg

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-09-03 23:36 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-29 15:38 v4 of legacy-display cleanup Daniel Kahn Gillmor
2019-08-29 15:38 ` [PATCH v4 1/8] mime-node: split out _mime_node_set_up_part Daniel Kahn Gillmor
2019-08-29 15:38 ` [PATCH v4 2/8] repair: set up codebase for repair functionality Daniel Kahn Gillmor
2019-08-29 15:38 ` [PATCH v4 3/8] test: avoid showing legacy-display parts Daniel Kahn Gillmor
2019-08-29 15:38 ` [PATCH v4 4/8] util/crypto: _n_m_crypto_potential_payload: rename "payload" arg to "part" Daniel Kahn Gillmor
2019-08-29 15:38 ` [PATCH v4 5/8] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload Daniel Kahn Gillmor
2019-08-29 15:38 ` [PATCH v4 6/8] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display Daniel Kahn Gillmor
2019-08-29 15:38 ` [PATCH v4 7/8] cli/{show,reply}: skip over legacy-display parts Daniel Kahn Gillmor
2019-08-29 15:38 ` [PATCH v4 8/8] index: avoid indexing " Daniel Kahn Gillmor
2019-09-03 23:34 ` v4 of legacy-display cleanup David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).