From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id F42196DE1062 for ; Sat, 11 May 2019 20:06:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.089 X-Spam-Level: X-Spam-Status: No, score=0.089 tagged_above=-999 required=5 tests=[AWL=-0.160, HEADER_FROM_DIFFERENT_DOMAINS=0.249] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id koj7EiHJbjrI for ; Sat, 11 May 2019 20:06:20 -0700 (PDT) X-Greylist: delayed 1203 seconds by postgrey-1.36 at arlo; Sat, 11 May 2019 20:06:19 PDT Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id E758F6DE0F1C for ; Sat, 11 May 2019 20:06:19 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hPeVA-0007NV-Ek; Sat, 11 May 2019 22:46:12 -0400 Received: (nullmailer pid 17656 invoked by uid 1000); Sun, 12 May 2019 02:46:10 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: [PATCH] test/emacs: revert invalid-from test to pre-86f89385 behaviour Date: Sat, 11 May 2019 20:45:59 -0600 Message-Id: <20190512024559.17612-1-david@tethera.net> X-Mailer: git-send-email 2.11.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 May 2019 03:06:21 -0000 To the best of my understanding, this original behaviour was what Carl's homebrew parser produced. With commit 86f89385 Austin switched to using GMime (2.6). This produced arguably worse results, but since the input was bad, we could live with it. Now with GMime 3.0 we are getting the original results again, and there is no reason to consider this test broken. --- test/T310-emacs.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh index c06a8133..5f74305d 100755 --- a/test/T310-emacs.sh +++ b/test/T310-emacs.sh @@ -86,14 +86,13 @@ test_emacs "(let ((notmuch-show-indent-messages-width 4)) test_expect_equal_file $EXPECTED/notmuch-show-thread-maildir-storage-with-fourfold-indentation OUTPUT test_begin_subtest "notmuch-show for message with invalid From" -test_subtest_known_broken add_message "[subject]=\"message-with-invalid-from\"" \ "[from]=\"\\\"Invalid \\\" From\\\" \"" thread=$(notmuch search --output=threads subject:message-with-invalid-from) test_emacs "(notmuch-show \"$thread\") (test-output \"OUTPUT.raw\")" cat <EXPECTED -"Invalid " (2001-01-05) (inbox) +Invalid " From (2001-01-05) (inbox) Subject: message-with-invalid-from To: Notmuch Test Suite Date: GENERATED_DATE -- 2.11.0