From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id C4B196DE0F5A for ; Thu, 9 May 2019 18:05:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.201 X-Spam-Level: X-Spam-Status: No, score=-0.201 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z-eTzQk6gQa8 for ; Thu, 9 May 2019 18:05:53 -0700 (PDT) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by arlo.cworth.org (Postfix) with ESMTPS id 77F296DE0F50 for ; Thu, 9 May 2019 18:05:53 -0700 (PDT) Received: by mail-io1-f65.google.com with SMTP id s20so3186478ioj.7 for ; Thu, 09 May 2019 18:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wdtz.org; s=google; h=date:message-id:from:to:subject:in-reply-to:references:mime-version; bh=jhDTPhHnjzTu91dl0zZ8HKaxBiJFQ1A7xAkfhsSTT8s=; b=D12zQHEx9I4mgKd78v6pWcittc+DaGVlSYUVsoDVuXVCgkuF8yFk8SM85r6bNMDcXf /fmY/rbApvjqX3zWQw4G0BMFr9ahi01Ll9l9DrYizVWQsP+wYi9eR99V89SDocDXy8FA 4Ku27C317rLhtBaY8lG7KDmjdsKspprI6W6U8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:subject:in-reply-to :references:mime-version; bh=jhDTPhHnjzTu91dl0zZ8HKaxBiJFQ1A7xAkfhsSTT8s=; b=j9bTgR1FJ9uCgVIMnG7Sfr2q/23Qy3LQAFb6qmK9WDZ1XJFbBl5j2I3BPQOiiuOeKq lJYGCLPdT3UGLr5ufcIeV35iAxdR3BeH+yYzfK7HJuj5MT7EQ1mQOkSW3to3tLbdbMIO jwLmt4eun5LSD3B4MbhAU864fOb9qBwTXYIFvGC5zQa/fHZdUXd3F8G6fs8zYqfpscMH Yz9OVmDlVJDpK0xXEC5zCp6b+r1Zmwt3DkF8rhqlswXIwC9nHtNQGg5fEmzo1tHKDmAh D6Axlvof8HbDYD2EBMTs8j+TbmepJIn4hou6F5jTaIxPVRxZ5x1i+bVsja8AY+zEOqOR m/Dw== X-Gm-Message-State: APjAAAXTcDZoUtljpFyyzIqiLfCX4KwvonIJTVFdzhmJeIPAHoXSfNPt 2KPRHVbUJu/OcBUm05VDt+6KKj5CBaNd X-Google-Smtp-Source: APXvYqzB8B92f06QFBjBNWHyC+gq6x1gupQooGr16/oazTXEB008+1n1fwGZievrmFeapMWPfuIokw== X-Received: by 2002:a5d:9d07:: with SMTP id j7mr2351265ioj.39.1557450350961; Thu, 09 May 2019 18:05:50 -0700 (PDT) Received: from localhost ([2600:1702:4010:14c8::d68]) by smtp.gmail.com with ESMTPSA id x74sm1801462itb.33.2019.05.09.18.05.48 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 09 May 2019 18:05:48 -0700 (PDT) Date: Thu, 9 May 2019 20:05:47 -0500 Message-ID: <20190509200547.GG24880@dtznix> From: Will Dietz To: notmuch@notmuchmail.org Subject: Re: [PATCH] lib/message-file: close stream in destructor In-Reply-To: <20190510002324.31140-1-david@tethera.net> References: <20190510002324.31140-1-david@tethera.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="TgHfAASkZQBIP+h5"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 May 2019 01:05:54 -0000 --TgHfAASkZQBIP+h5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: base64 R3JlYXQsIHRoYW5rIHlvdSEKCk11Y2ggYXBwcmVjaWF0ZWQsIEkgYWN0dWFsbHkgd2FzIHJ1bm5p bmcgaW50byB0aGlzIHllc3RlcmRheS4KCiggd2hpY2ggZm9yIHdoYXRldmVyIHJlYXNvbiBsZWQg dG8gcG9zdGluZyB0aGlzIG9uIHRoZSBzdWJqZWN0OgpodHRwczovL2dpdGh1Yi5jb20vYWZld21h aWwvYWZldy9pc3N1ZXMvMTkzI2lzc3VlY29tbWVudC00OTA3NjY4NTAgKQoKV291bGQgdGhlIHZh bGdyaW5kIHN1cHBvcnQgaW4gdGhlIHRlc3Qgc3VpdGUgY2F0Y2ggdGhpcyBzb3J0IG9mIHRoaW5n CihmZCBsZWFrIG9uIHJlbGF0aXZlbHkgY29tbW9uIHBhdGgpPwoKUmVnYXJkbGVzcywgZ2xhZCB0 byBzZWUgaXQgZml4ZWQhCgp+V2lsbAoKT24gVGh1LCAgOSBNYXkgMjAxOSAyMToyMzoyNCAtMDMw MCwgRGF2aWQgQnJlbW5lciA8ZGF2aWRAdGV0aGVyYS5uZXQ+IHdyb3RlOgo+IFdpdGhvdXQgdGhp cywKPiAKPiAkIG1ha2UgdGltZS10ZXN0IE9QVElPTlM9LS1zbWFsbAo+IAo+IGxlYWRzIHRvIGZh dGFsIGVycm9ycyBmcm9tIHRvbyBtYW55IG9wZW4gZmlsZXMuCj4gCj4gVGhhbmtzIHRvIHN0LWdv dXJpY2hvbi1maWQgZm9yIGJyaW5naW5nIHRoaXMgcHJvYmxlbSB0byBteSBhdHRlbnRpb24gaW4g SVJDLgo+IC0tLQo+ICBsaWIvbWVzc2FnZS1maWxlLmMgfCAzICsrKwo+ICAxIGZpbGUgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspCj4gCj4gVGhlIHJlZ3Jlc3Npb24gdGVzdCBjb3VsZCBiZSBpbXBy b3ZlZCwgYnV0IEkgd2FudGVkIHRvIGdldCBhIGZpeCBvdXQKPiBhbmQgaG9wZWZ1bGx5IGludG8g bWFzdGVyLCBhcyB0aGlzIGlzIGEgcHJvYmxlbSB0aGF0IHNlZW1zCj4gcGFydGljdWxhcmx5IGxp a2VseSB0byBoaXQgbmV3IHVzZXJzIGR1cmluZyB0aGVpciBpbml0aWFsIG5vdG11Y2gtbmV3Lgo+ IAo+IGRpZmYgLS1naXQgYS9saWIvbWVzc2FnZS1maWxlLmMgYi9saWIvbWVzc2FnZS1maWxlLmMK PiBpbmRleCA1MDg1NTA2Ny4uMjRjNWZkYTQgMTAwNjQ0Cj4gLS0tIGEvbGliL21lc3NhZ2UtZmls ZS5jCj4gKysrIGIvbGliL21lc3NhZ2UtZmlsZS5jCj4gQEAgLTQ2LDYgKzQ2LDkgQEAgX25vdG11 Y2hfbWVzc2FnZV9maWxlX2Rlc3RydWN0b3IgKG5vdG11Y2hfbWVzc2FnZV9maWxlX3QgKm1lc3Nh Z2UpCj4gICAgICBpZiAobWVzc2FnZS0+bWVzc2FnZSkKPiAgCWdfb2JqZWN0X3VucmVmIChtZXNz YWdlLT5tZXNzYWdlKTsKPiAgCj4gKyAgICBpZiAobWVzc2FnZS0+c3RyZWFtKQo+ICsJZ19vYmpl Y3RfdW5yZWYgKG1lc3NhZ2UtPnN0cmVhbSk7Cj4gKwo+ICAgICAgcmV0dXJuIDA7Cj4gIH0KPiAg Cj4gLS0gCj4gMi4yMC4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBub3RtdWNoIG1haWxpbmcgbGlzdAo+IG5vdG11Y2hAbm90bXVjaG1haWwu b3JnCj4gaHR0cHM6Ly9ub3RtdWNobWFpbC5vcmcvbWFpbG1hbi9saXN0aW5mby9ub3RtdWNoCg== --TgHfAASkZQBIP+h5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEGP2VA3qVZfcHsXor67DqQSSAnQIFAlzUzmsACgkQ67DqQSSA nQJBRA//bHujiornjKB50KKB+6lYoroyVJJL+GaWYyVIryR2MjEa0uiWPTVsWes2 ZfWSnnu90icJmnSMfHOAC+UrJybTZzMcX1LcDfJAoiyiKFcLX73S462gseTC/fNT 5dCwOS9ba1Xi4v3B1nvok5yYq1OaxtpAOWn+QVAHI1RE1YQjt/bqQsl3rkYQLOZ4 pN6nh8+2z6XOOhGZRuVeYC8N8RH1X68Ov/LVpOsYsLYnvMEs07MN4hlCp7Z+jYjK LVogv2WRmDBR/jTBvLK0++l8hX9a6vKz0oQTqoCCv1hwYHWfGuTxY+zt5az8rzIQ aFt7MWuwPRlYUOIqFcHoWvjJ6biQFs/g/t3yABHUDCsyoT0ofajB7WJc4VkYitfM Hdw43nbZy+lScR8miNK+MSS+Qs8ifFXBUFl8YuJagUw3ehWuMRaKkpy+S2HrK2rp KZ8rjTWIF16UZfLNdC0i0+Ro28qRHpw/hQzWDZSTHXs3ZO0nNSbxl06n0DtIvUvg 4pREwUDaA/lVpulZ5gjUyqQhonk/iGmYoMVbFUSaiMe0f8yFKAovEuxg9I0h0jhD QxhHA5OURl9FHuYnp8laYCyXCT1z3BBm8eX8Li1Ee0xqHEZbn+EFBziy6zKUJFqR JQuu/gJ3zKREZETTPQ87y4RxTzXuzkPN1hOc98BX+M5rTvSFcUo= =PPeR -----END PGP SIGNATURE----- --TgHfAASkZQBIP+h5--