From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Cc: 35370@debbugs.gnu.org
Subject: [PATCH] emacs: drop use of message-default-charset
Date: Mon, 22 Apr 2019 16:51:16 -0400 [thread overview]
Message-ID: <20190422205116.10694-1-dkg@fifthhorseman.net> (raw)
In-Reply-To: <831s1u6ofj.fsf@gnu.org>
Apparently, message-default-charset is deprecated, which causes the
following warning messages during the build:
In notmuch-maildir-setup-message-for-saving:
emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an
obsolete variable (as of 26.1); The default charset comes from the
language environment
In discussion with emacs upstream over on
https://debbugs.gnu.org/35370, it appears that we can just drop this
entirely and things should still work with emacs 25.
---
emacs/notmuch-maildir-fcc.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index 1551e8b6..ae56bacd 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -169,8 +169,7 @@ This is taken from the function message-do-fcc."
(message-encode-message-body)
(save-restriction
(message-narrow-to-headers)
- (let ((mail-parse-charset message-default-charset))
- (mail-encode-encoded-word-buffer)))
+ (mail-encode-encoded-word-buffer))
(goto-char (point-min))
(when (re-search-forward
(concat "^" (regexp-quote mail-header-separator) "$")
--
2.20.1
next prev parent reply other threads:[~2019-04-22 20:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 20:00 notmuch-emacs: avoiding deprecated message-default-charset Daniel Kahn Gillmor
2019-04-21 14:41 ` David Bremner
2019-04-21 19:25 ` Daniel Kahn Gillmor
2019-04-21 22:05 ` bug#35370: " Noam Postavsky
2019-04-22 1:55 ` Daniel Kahn Gillmor
2019-04-22 6:33 ` Eli Zaretskii
2019-04-22 14:21 ` Daniel Kahn Gillmor
2019-04-22 15:37 ` Eli Zaretskii
2019-04-22 20:51 ` Daniel Kahn Gillmor [this message]
2019-04-22 21:23 ` [PATCH] emacs: drop use of message-default-charset Tomi Ollila
2019-05-07 9:38 ` David Bremner
2019-05-07 12:26 ` bug#35370: notmuch-emacs: avoiding deprecated message-default-charset Noam Postavsky
2019-05-07 14:36 ` Eli Zaretskii
2019-05-09 18:33 ` Lars Ingebrigtsen
2019-05-10 5:32 ` Eli Zaretskii
2019-05-10 10:45 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422205116.10694-1-dkg@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=35370@debbugs.gnu.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).