From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 04AD66DE0EA6 for ; Sun, 10 Mar 2019 12:28:09 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PHqkg7IyMDNA for ; Sun, 10 Mar 2019 12:28:07 -0700 (PDT) Received: from wp260.webpack.hosteurope.de (wp260.webpack.hosteurope.de [80.237.133.29]) by arlo.cworth.org (Postfix) with ESMTPS id 7292D6DE0BA2 for ; Sun, 10 Mar 2019 12:28:07 -0700 (PDT) Received: from p200300cb273ada0124d27f36daada354.dip0.t-ipconnect.de ([2003:cb:273a:da01:24d2:7f36:daad:a354] helo=deneb.skynet.aixah.de); authenticated by wp260.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1h3478-0008BE-1p; Sun, 10 Mar 2019 20:28:02 +0100 Received: by deneb.skynet.aixah.de (Postfix, from userid 1005) id 91124C0305; Sun, 10 Mar 2019 20:28:01 +0100 (CET) Date: Sun, 10 Mar 2019 20:28:01 +0100 From: Luis Ressel To: David Bremner Cc: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] Add a configure flag to disable rpaths Message-ID: <20190310192801.7ud4d34m4iouofur@deneb.skynet.aixah.de> Mail-Followup-To: David Bremner , Tomi Ollila , notmuch@notmuchmail.org References: <20190226020649.5407-1-aranea@aixah.de> <8736o6zs3m.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: ? Content-Disposition: inline In-Reply-To: <8736o6zs3m.fsf@tethera.net> User-Agent: NeoMutt/20180716 X-bounce-key: webpack.hosteurope.de;aranea@aixah.de;1552246087;e59b3dcd; X-HE-SMSGID: 1h3478-0008BE-1p X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Mar 2019 19:28:09 -0000 On Fri, Mar 01, 2019 at 08:39:25AM -0400, David Bremner wrote: > Tomi Ollila writes: > > > On Tue, Feb 26 2019, Luis Ressel wrote: > > > > although the commit message is a bit terse, this change looks simple and > > reasonable enough to be pushed (i.e. if i think hard I can see reason > > for this change even it is not described in commit message ;D) > > > > For those of us too lazy to think hard, what is the reason? I can add to > the commit message. > Packagers often disable rpaths wherever possible. They can cause confusion and, used carelessly, even security issues, and in the vast majority of cases they're wholly unneccessary. notmuch's usage of rpaths is rather innocuous, but I would still prefer to disable them when they're not strictly needed. Now, notmuch's configure script already tries to detect whether $libdir is path of the standard library search path and disables -rpath in this case. However, this detection logic invokes /sbin/ldconfig, which may not be present on musl-based systems or at least not work as the configure script expects. On my host, configure thus arrives at the conclusion it needs to use -rpath even though $libdir is set to /usr/lib/. Since it seemed easy and straightforward to just add an option to explicitly disable rpaths, and I wanted to avoid adding musl-specific code to the autodetection logic, I decided to go this route. Cheers, Luis Ressel (Resending due to trouble with my new MUA; apologies if you receive this mail twice.)