From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id B1B036DE0ECC for ; Sun, 3 Mar 2019 12:41:24 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.01 X-Spam-Level: X-Spam-Status: No, score=-0.01 tagged_above=-999 required=5 tests=[AWL=-0.009, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id olMBlp288oZx for ; Sun, 3 Mar 2019 12:41:23 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 9C4586DE0C1F for ; Sun, 3 Mar 2019 12:41:23 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1h0XvF-0001XO-Ib; Sun, 03 Mar 2019 15:41:21 -0500 Received: (nullmailer pid 2608 invoked by uid 1000); Sun, 03 Mar 2019 20:41:19 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: [PATCH] doc: sequentialize calls to sphinx-build Date: Sun, 3 Mar 2019 16:40:19 -0400 Message-Id: <20190303204018.2544-1-david@tethera.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Mar 2019 20:41:24 -0000 In certain conditions the parallel calls to sphinx-build could collide, yielding a crash like Exception occurred: File "/usr/lib/python3/dist-packages/sphinx/environment.py", line 1261, in get_doctree doctree = pickle.load(f) EOFError: Ran out of input --- I first observed this on Debian/ppc64le. There it occured about 1 in 50 builds. Thanks to Olly Betts for pointing me in the right direction. doc/Makefile.local | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/Makefile.local b/doc/Makefile.local index 16459e35..eed243a0 100644 --- a/doc/Makefile.local +++ b/doc/Makefile.local @@ -37,6 +37,13 @@ INFO_INFO_FILES := $(INFO_TEXI_FILES:.texi=.info) %.gz: % rm -f $@ && gzip --stdout $^ > $@ +# Sequentialize the calls to sphinx-build to avoid races with +# reading/writing state. + +sphinx-html: | $(DOCBUILDDIR)/.roff.stamp +sphinx-texinfo: | sphinx-html +sphinx-info: | sphinx-texinfo + sphinx-html: $(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(DOCBUILDDIR)/html -- 2.20.1