From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 5293F6DE0F3E for ; Tue, 12 Feb 2019 18:17:35 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.006 X-Spam-Level: X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5 tests=[AWL=-0.005, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2L3SmrP-FRU5 for ; Tue, 12 Feb 2019 18:17:34 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 063D66DE0ED9 for ; Tue, 12 Feb 2019 18:17:33 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1gtk73-0005vz-Tc; Tue, 12 Feb 2019 21:17:25 -0500 Received: (nullmailer pid 18470 invoked by uid 1000); Wed, 13 Feb 2019 02:17:24 -0000 From: David Bremner To: Carl Worth , David Bremner , Adam Majer , notmuch@notmuchmail.org Subject: [PATCH] build: sign tarball instead of sha256sum Date: Tue, 12 Feb 2019 22:17:03 -0400 Message-Id: <20190213021703.18412-1-david@tethera.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87mun16gmm.fsf@wondoo.home.cworth.org> References: <87mun16gmm.fsf@wondoo.home.cworth.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 02:17:35 -0000 Adam Majer pointed out in [1] the way were signing releases was unusual. Neither Carl nor I could think of a good reason for explicitely signing the checksum (internally of course that's what GPG is going anyway). [1] mid:b3fd556d-c346-7af9-a7a2-13b0f3235071@suse.de --- I think this does the trick, although the release stuff is always a bit tricky to test. Makefile.global | 2 +- Makefile.local | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.global b/Makefile.global index cae4c7d1..6e17494a 100644 --- a/Makefile.global +++ b/Makefile.global @@ -44,7 +44,7 @@ TAR_FILE=$(PACKAGE)-$(VERSION).tar.gz ELPA_FILE:=$(PACKAGE)-emacs-$(ELPA_VERSION).tar DEB_TAR_FILE=$(PACKAGE)_$(VERSION).orig.tar.gz SHA256_FILE=$(TAR_FILE).sha256 -GPG_FILE=$(SHA256_FILE).asc +GPG_FILE=$(TAR_FILE).asc PV_FILE=bindings/python/notmuch/version.py diff --git a/Makefile.local b/Makefile.local index 82145e1b..01ba49cc 100644 --- a/Makefile.local +++ b/Makefile.local @@ -42,8 +42,8 @@ $(TAR_FILE): $(SHA256_FILE): $(TAR_FILE) sha256sum $^ > $@ -$(GPG_FILE): $(SHA256_FILE) - gpg --armor --sign $^ +$(GPG_FILE): $(TAR_FILE) + gpg --armor --detach-sign $^ .PHONY: dist dist: $(TAR_FILE) -- 2.20.1