From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: BUG: "notmuch insert" fails with "Delivery of non-mail file"
Date: Mon, 21 Jan 2019 16:53:58 -0300 [thread overview]
Message-ID: <201901211953.q5nxxkrlghgp@alvherre.pgsql> (raw)
In-Reply-To: <87pnssqzpf.fsf@tethera.net>
Hi David, thanks for replying.
On 2019-Jan-19, David Bremner wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>
> > In my read of the code ultimately comes from
> > g_mime_parser_construct_message rejecting the message.
> > I reported this to GMime, and they said that the problem is that notmuch
> > insert is using the mbox mode:
> > https://github.com/jstedfast/gmime/issues/58
> > (Sample email is attached there).
>
> This issue (or a related one) has come up before
>
> https://nmbug.notmuchmail.org/nmweb/search/postfix+mbox
>
> Generally it seems to be caused by tools that add mbox 'From ' headers,
> without actually mbox escaping the file. We haven't yet reached
> consensus on a good solution (generally people just want to fix their
> own mail, which is understandable). A workaround discussed in the
> messages I reference above is to strip the 'From ' header before passing
> to notmuch-insert. Perhaps some scholar of the RFCs can convince us that
> that is "always" the right thing for notmuch insert to do.
I'm not sure I follow. As I understand, notmuch does not work with
mboxes, only with maildirs, so the behavior of splitting emails at "From
" is not strictly necessary, since one file always equals one message.
As for RFC scholarship, I spent some time looking at
https://tools.ietf.org/html/rfc5322 to see if it defined any sort of
message separator ... but as far as I can tell, it only defines what
does a valid message looks like. It doesn't say where does one message
end.
On the other hand, in my world, it's been quite a while since 'From '
was considered a useful message separator. This stopped being true in a
pretty extensive way when git-format-patches messages started being
posted as attachments. But even before that, MUAs stopped adding the
">" at the start of a "From " line in human-written text. Nowadays what
really governs the split is the Content-Length header, from the MIME
definitions. Most tools do not escape lines starting with 'From '
anymore. As far as I can tell, this is defined by RFC-2049,
https://tools.ietf.org/html/rfc2046#section-5.1.1 which states that the
implementation must look for the "boundary delimitir line". Stopping at
a "From " line before finding the boundary delimiter line would be a
mistake, in my reading.
> > As far as I can tell, this is all coming from
> > _notmuch_message_file_parse() which sets the is_mbox flag when it sees
> > the "^From " line at the start of the file ... which kinda makes sense
> > in general terms, but for notmuch-insert I think that's the wrong thing
> > to do. Maybe a solution is to pass a flag down from notmuch-insert.c's
> > add_file all the way down to _notmuch_message_file_parse telling it not
> > to treat the file as an mbox.
>
> I'd be worried about letting notmuch-insert deliver messages that
> notmuch-new would not be able to parse. In particular we'd like to keep
> the property that a Maildir + the output of notmuch-dump should be
> enough to completely recover the notmuch database.
Hmm, that's a good point -- I assume that notmuch-new should be patched
similarly so that those messages are valid there too.
So maybe the solution (given that, as I said above, Notmuch does not
appear to handle mboxes at all) is to just set the mbox flag to false
completely ...
--
Álvaro Herrera PostgreSQL Expert, https://www.2ndQuadrant.com/
next prev parent reply other threads:[~2019-01-21 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 16:07 BUG: "notmuch insert" fails with "Delivery of non-mail file" Alvaro Herrera
2019-01-19 18:17 ` David Bremner
2019-01-21 19:53 ` Alvaro Herrera [this message]
2019-02-01 19:33 ` David Bremner
2019-03-07 6:57 ` Leo L. Schwab
2019-03-07 21:05 ` David Bremner
2019-03-07 22:03 ` Alvaro Herrera
2019-03-07 22:34 ` David Bremner
2019-03-08 0:51 ` Alvaro Herrera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201901211953.q5nxxkrlghgp@alvherre.pgsql \
--to=alvherre@alvh.no-ip.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).