From: Markus Weimar <markus.weimar@gmail.com>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [FEATURE] Purge ignored messages from index
Date: Fri, 23 Nov 2018 16:11:40 +0100 [thread overview]
Message-ID: <20181123151140.GA4229@lati.localdomain> (raw)
In-Reply-To: <87muq0rg5n.fsf@tethera.net>
On Thu, 2018-11-22 16:49:56 -0400, David Bremner wrote:
> Notmuch new works very hard to not visit files that haven't
> changed. Changing this would have a big negative performance impact, afaik.
I see. I thought it might be possible to purge the entries without looking at any files by doing a cheap comparison of indexed file path against ignored patterns. If that’s not possible, I agree that ´new´ shouldn’t be slowed down for this edge case.
> I care less about the performance of reindex; also it already
> rescans all the relevant messages, so I guess the performance impact
> would not be that bad.
Makes sense to me. Short notes in the docs and config file to run ´reindex 'folder:<pattern>'´ after adding new ignore patterns would prevent any such confusion.
Take care,
Markus
next prev parent reply other threads:[~2018-11-23 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 12:45 [FEATURE] Purge ignored messages from index Markus Weimar
2018-11-22 17:33 ` David Bremner
2018-11-22 17:47 ` Jeremy Nickurak
2018-11-22 17:58 ` David Bremner
2018-11-22 19:26 ` Markus Weimar
2018-11-22 20:49 ` David Bremner
2018-11-23 15:11 ` Markus Weimar [this message]
2018-11-23 15:56 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123151140.GA4229@lati.localdomain \
--to=markus.weimar@gmail.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).