From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [RFC patch 1/5] cli/config: refactor _stored_in_db
Date: Sat, 17 Nov 2018 10:08:57 -0400 [thread overview]
Message-ID: <20181117140901.1870-2-david@tethera.net> (raw)
In-Reply-To: <20181117140901.1870-1-david@tethera.net>
This will make it easier to add other prefixes that are stored in the
database, compared to special casing each one as "query." was.
---
notmuch-config.c | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/notmuch-config.c b/notmuch-config.c
index bf77cc9d..1517d0ff 100644
--- a/notmuch-config.c
+++ b/notmuch-config.c
@@ -821,17 +821,26 @@ _item_split (char *item, char **group, char **key)
#define BUILT_WITH_PREFIX "built_with."
+struct config_key {
+ const char *name;
+ bool prefix;
+};
+
static bool
_stored_in_db (const char *item)
{
- const char * db_configs[] = {
- "index.decrypt",
+ struct config_key db_configs[] = {
+ {"index.decrypt", false},
+ {"query.", true},
};
- if (STRNCMP_LITERAL (item, "query.") == 0)
- return true;
- for (size_t i = 0; i < ARRAY_SIZE (db_configs); i++)
- if (strcmp (item, db_configs[i]) == 0)
+ for (size_t i = 0; i < ARRAY_SIZE (db_configs); i++) {
+ if (db_configs[i].prefix &&
+ strncmp (item, db_configs[i].name,
+ strlen(db_configs[i].name)) == 0)
return true;
+ if (strcmp (item, db_configs[i].name) == 0)
+ return true;
+ }
return false;
}
--
2.19.1
next prev parent reply other threads:[~2018-11-17 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 14:08 Draft of indexing user defined headers David Bremner
2018-11-17 14:08 ` David Bremner [this message]
2018-11-17 14:08 ` [RFC patch 2/5] cli/config: support user header index config David Bremner
2018-11-17 14:08 ` [RFC patch 3/5] lib: setup user headers in query parser David Bremner
2018-11-17 14:09 ` [RFC patch 4/5] WIP: store user prefixes David Bremner
2018-11-17 14:09 ` [RFC patch 5/5] WIP: index user headers David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181117140901.1870-2-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).