From: David Edmondson <dme@dme.org>
To: notmuch@notmuchmail.org
Subject: [PATCH v3 4/4] emacs: Improve the reporting of key activity
Date: Mon, 1 Oct 2018 17:06:33 +0100 [thread overview]
Message-ID: <20181001160633.26775-5-dme@dme.org> (raw)
In-Reply-To: <20181001160633.26775-1-dme@dme.org>
Improve the information provided about key retrieval and key validity.
---
emacs/notmuch-crypto.el | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
index 99087d0b..553ddca8 100644
--- a/emacs/notmuch-crypto.el
+++ b/emacs/notmuch-crypto.el
@@ -147,13 +147,16 @@ by user FROM."
(insert "\n"))
(defun notmuch-crypto-sigstatus-good-callback (button)
- (let* ((sigstatus (button-get button :notmuch-sigstatus))
+ (let* ((id (notmuch-show-get-message-id))
+ (sigstatus (button-get button :notmuch-sigstatus))
(fingerprint (concat "0x" (plist-get sigstatus :fingerprint)))
(buffer (get-buffer-create "*notmuch-crypto-gpg-out*"))
(window (display-buffer buffer)))
(with-selected-window window
(with-current-buffer buffer
(goto-char (point-max))
+ (insert (format "-- Key %s in message %s:\n"
+ fingerprint id))
(call-process notmuch-crypto-gpg-program nil t t "--list-keys" fingerprint))
(recenter -1))))
@@ -209,10 +212,14 @@ corresponding key when the status button is pressed."
(progn
(notmuch-crypto--set-button-label
button (format "Retrieving key %s asynchronously..." keyid))
+ (with-current-buffer buffer
+ (goto-char (point-max))
+ (insert (format "--- Retrieving key %s:\n" keyid)))
(let ((p (make-process :name "notmuch GPG key retrieval"
+ :connection-type 'pipe
:buffer buffer
+ :stderr buffer
:command (list notmuch-crypto-gpg-program "--recv-keys" keyid)
- :connection-type 'pipe
:sentinel #'notmuch-crypto--async-key-sentinel
;; Create the process stopped so that
;; we have time to store the key id,
@@ -228,6 +235,7 @@ corresponding key when the status button is pressed."
(with-selected-window window
(with-current-buffer buffer
(goto-char (point-max))
+ (insert (format "--- Retrieving key %s:\n" keyid))
(call-process notmuch-crypto-gpg-program nil t t "--recv-keys" keyid)
(insert "\n")
(call-process notmuch-crypto-gpg-program nil t t "--list-keys" keyid))
--
2.19.0
next prev parent reply other threads:[~2018-10-01 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 16:06 [PATCH v3 0/4] Retrieve GPG keys asynchronously David Edmondson
2018-10-01 16:06 ` [PATCH v3 1/4] emacs: Asynchronous retrieval of GPG keys David Edmondson
2019-01-15 2:08 ` David Bremner
2019-01-19 11:15 ` David Edmondson
2019-01-19 12:47 ` David Bremner
2018-10-01 16:06 ` [PATCH v3 2/4] emacs: Minor refactoring of crypto code David Edmondson
2018-10-01 16:06 ` [PATCH v3 3/4] emacs: Add notmuch-crypto-gpg-program and use it David Edmondson
2018-10-01 16:06 ` David Edmondson [this message]
2019-09-03 23:49 ` [PATCH v3 0/4] Retrieve GPG keys asynchronously David Bremner
2019-09-12 1:33 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001160633.26775-5-dme@dme.org \
--to=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).