From: Olly Betts <olly@survex.com>
To: David Bremner <david@tethera.net>
Cc: James Aylett <james@tartarus.org>,
notmuch@notmuchmail.org, xapian-discuss@lists.xapian.org
Subject: Re: xapian parser bug?
Date: Sun, 30 Sep 2018 21:43:27 +0100 [thread overview]
Message-ID: <20180930204327.a4dwzh6jdqcqvk2e@survex.com> (raw)
In-Reply-To: <87y3bj198a.fsf@tethera.net>
On Sun, Sep 30, 2018 at 09:05:25AM -0300, David Bremner wrote:
> if (str.find (' ') != std::string::npos)
> query_str = '"' + str + '"';
> else
> query_str = str;
>
> return parser.parse_query (query_str, NOTMUCH_QUERY_PARSER_FLAGS, term_prefix);
I wouldn't recommend trying to generate strings to feed to QueryParser
like this code seems to be doing. QueryParser aims to parse input from
humans not machines.
As well as the case where str is an operation name, the code above looks
like it will mishandle cases where str contains a tab or double quotes.
There are likely other problem cases too.
Cheers,
Olly
next prev parent reply other threads:[~2018-09-30 20:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 22:09 xapian parser bug? David Bremner
2018-09-30 8:50 ` James Aylett
2018-09-30 9:20 ` Olly Betts
2018-09-30 12:05 ` David Bremner
2018-09-30 17:49 ` David Bremner
2018-09-30 20:43 ` Olly Betts [this message]
2018-10-01 1:25 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180930204327.a4dwzh6jdqcqvk2e@survex.com \
--to=olly@survex.com \
--cc=david@tethera.net \
--cc=james@tartarus.org \
--cc=notmuch@notmuchmail.org \
--cc=xapian-discuss@lists.xapian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).