From: David Edmondson <dme@dme.org>
To: notmuch@notmuchmail.org
Subject: [PATCH v1 2/2] emacs: Call `notmuch-mua-send-hook' hooks when sending a message
Date: Tue, 25 Sep 2018 16:09:10 +0100 [thread overview]
Message-ID: <20180925150910.22318-3-dme@dme.org> (raw)
In-Reply-To: <20180925150910.22318-1-dme@dme.org>
Previously any hook functions attached to `notmuch-mua-send-hook' were
ignored.
---
emacs/notmuch-mua.el | 1 +
test/T310-emacs.sh | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index fc8ac687..df2ac447 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -543,6 +543,7 @@ unencrypted. Really send? "))))
(defun notmuch-mua-send-common (arg &optional exit)
(interactive "P")
+ (run-hooks 'notmuch-mua-send-hook)
(when (and (notmuch-mua-check-no-misplaced-secure-tag)
(notmuch-mua-check-secure-tag-has-newline))
(letf (((symbol-function 'message-do-fcc) #'notmuch-maildir-message-do-fcc))
diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh
index d743abb7..5935819f 100755
--- a/test/T310-emacs.sh
+++ b/test/T310-emacs.sh
@@ -1107,7 +1107,6 @@ output=$(test_emacs "(mapcar 'notmuch-escape-boolean-term (list
test_expect_equal "$output" '("\"\"" "abc`~!@#$%^&*-=_+123" "\"(abc\"" "\")abc\"" "\"\"\"abc\"" "\"'$'\x01''xyz\"" "\"“xyz”\"")'
test_begin_subtest "Sending a message calls the send message hooks"
-test_subtest_known_broken
emacs_deliver_message \
'Testing message sending hooks' \
'This is a test of the message sending hooks.' \
--
2.19.0
next prev parent reply other threads:[~2018-09-25 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 15:09 [PATCH v1 0/2] `notmuch-mua-send-hook' was ignored David Edmondson
2018-09-25 15:09 ` [PATCH v1 1/2] test: Check that `notmuch-mua-send-hook' is called on sending a message David Edmondson
2018-09-27 1:29 ` David Bremner
2018-09-25 15:09 ` David Edmondson [this message]
2018-09-27 1:39 ` [PATCH v1 2/2] emacs: Call `notmuch-mua-send-hook' hooks when " David Bremner
2018-09-29 0:12 ` David Bremner
2018-09-30 1:06 ` David Bremner
2018-10-01 9:56 ` David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925150910.22318-3-dme@dme.org \
--to=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).