From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id B77166DE022D for ; Sun, 16 Sep 2018 05:41:51 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.002 X-Spam-Level: X-Spam-Status: No, score=0.002 tagged_above=-999 required=5 tests=[AWL=0.013, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hAcBCwZGYVN8 for ; Sun, 16 Sep 2018 05:41:50 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 70AC56DE021A for ; Sun, 16 Sep 2018 05:41:50 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1g1WN1-0003wF-Qx; Sun, 16 Sep 2018 08:41:47 -0400 Received: (nullmailer pid 14931 invoked by uid 1000); Sun, 16 Sep 2018 12:41:46 -0000 From: David Bremner To: Vincent Breitmoser , notmuch@notmuchmail.org Subject: Updated zsh completion patches Date: Sun, 16 Sep 2018 09:41:39 -0300 Message-Id: <20180916124141.14851-1-david@tethera.net> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180915223428.25961-1-look@my.amazin.horse> References: <20180915223428.25961-1-look@my.amazin.horse> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2018 12:41:51 -0000 Hi Vincent; Thanks for this patch, it's definitely a big improvement. I had to make some small adjustments to the install recipes to accomodate the renaming / removal of notmuch-completion.zsh. A revised version of your patch with that squashed in follows. I also added a patch to install the completion files properly on Debian. That could be squashed in, or left as a seperate patch. I do have one problem with the completion of tags. It seems the treatment of tags with :: in them is not consistent. If I run % notmuch tag +foo::bar tag:foo::bar for some existing tag foo::bar, the second one fails to complete C-x h yields something like the following ╭─ convex:~ ╰─% notmuch tag +inbox::notmuch tag:inbox: tags in context :completion::complete:notmuch:: argument-rest (_arguments _notmuch) tags in context :completion::complete:notmuch:argument-rest: normal-argument-rest (_arguments _notmuch_tag _notmuch_command _arguments _notmuch) tags in context :completion::complete:notmuch:normal-argument-rest: normal-argument-rest (_message _notmuch_search_term _notmuch_tagging_or_search _arguments _notmuch_tag _notmuch_command _arguments _notmuch)