From: Olly Betts <olly@survex.com>
To: David Bremner <david@tethera.net>
Cc: Mueen Nawaz <mueen@nawaz.org>,
notmuch@notmuchmail.org, xapian-discuss@lists.xapian.org
Subject: Re: Notmuch DB Problems
Date: Mon, 10 Sep 2018 22:24:01 +0100 [thread overview]
Message-ID: <20180910212400.zxcj3ibfwpzbhzsw@survex.com> (raw)
In-Reply-To: <87a7opk45p.fsf@tethera.net>
On Mon, Sep 10, 2018 at 08:01:06AM -0300, David Bremner wrote:
> Mueen Nawaz <mueen@nawaz.org> writes:
> > Now killing all those jobs did not fix the database. It was still
> > broken. And as we saw the second time round, it was /really/ broken - it
> > would not even open in read-only mode.
>
> That seems like something the Xapian devs (in copy) might be interested
> in fixing, if you could come up with a simple reproducer.
I'm certainly happy to investigate if someone can provide a way for
me to make it happen on demand.
It doesn't make much sense to me that holding the lock alone could be
causing any sort of corruption - that's just an fcntl() lock.
I would suggest to make sure you're running Xapian 1.4.7 as that fixed a
cursor handling bug which affected notmuch. I didn't find a way to make
it corrupt on-disk data, but it's hard to be completely certain that it
couldn't ever do that, so ruling out that as a cause would be good.
> notmuch could be cleverer about timing out on trying to acquire a
> lock. I suspect it's a bit delicate to get that right, and I've been
> hoping the underlying primitives would get a bit more flexible
> w.r.t. locking.
You mean in Xapian? If so, a wishlist bug saying what you're hoping
for might help it happen.
Cheers,
Olly
next prev parent reply other threads:[~2018-09-10 22:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 1:00 Notmuch DB Problems mueen
2018-09-05 18:05 ` Jani Nikula
2018-09-07 15:32 ` Mueen Nawaz
2018-09-10 11:01 ` David Bremner
2018-09-10 14:21 ` Mueen Nawaz
2018-09-10 15:08 ` David Bremner
2018-09-10 15:19 ` Mueen Nawaz
2018-09-10 21:24 ` Olly Betts [this message]
2018-09-10 23:45 ` David Bremner
2018-09-12 2:41 ` Mueen Nawaz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910212400.zxcj3ibfwpzbhzsw@survex.com \
--to=olly@survex.com \
--cc=david@tethera.net \
--cc=mueen@nawaz.org \
--cc=notmuch@notmuchmail.org \
--cc=xapian-discuss@lists.xapian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).