Bug: INSTALL should mention python3-sphinx not python-sphinx

Bug: INSTALL should mention python3-sphinx not python-sphinx

[Antoine Amarilli]

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

Hi all,

In the current master (a727e7d4d398375c4a3ba5020e2ab25b5b874785),
INSTALL contains:

  For Debian and similar:

        sudo apt-get install libxapian-dev libgmime-3.0-dev libtalloc-dev zlib1g-dev python-sphinx

However it seems like what is currently used is python3-sphinx, cf
commit 03f4f75124c6d9882b8306873e8908aac9eee2bb. At least on my system,
when I have just python-sphinx installed instead of python3-sphinx,
./configure says it will not build man pages, whereas it works with
python3-sphinx.

So I think the line above should be changed. Probably the Fedora line
just below needs to be changed too, but I don't know how their packaging
work (do they have a python3-sphinx package or not).

Thanks!

-- 
Antoine Amarilli


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH 1/2] INSTALL: refer to python3-sphinx

[Daniel Kahn Gillmor]

We're now preferring to build with python3 instead of python2.  Update
the INSTALL to match.

Thanks to Antoine Amarilli <a3nm@a3nm.net> for pointing this out!
---
 INSTALL | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/INSTALL b/INSTALL
index 875014f0..4a0dc741 100644
--- a/INSTALL
+++ b/INSTALL
@@ -88,11 +88,11 @@ dependencies with a simple simple command line. For example:
 
   For Debian and similar:
 
-        sudo apt-get install libxapian-dev libgmime-3.0-dev libtalloc-dev zlib1g-dev python-sphinx
+        sudo apt-get install libxapian-dev libgmime-3.0-dev libtalloc-dev zlib1g-dev python3-sphinx
 
   For Fedora and similar:
 
-	sudo yum install xapian-core-devel gmime-devel libtalloc-devel zlib-devel python-sphinx
+	sudo yum install xapian-core-devel gmime-devel libtalloc-devel zlib-devel python3-sphinx
 
 On other systems, a similar command can be used, but the details of
 the package names may be different.
-- 
2.15.1

[PATCH 2/2] travis: build against python3-sphinx instead of python-sphinx

[Daniel Kahn Gillmor]

Ubuntu trusty has python3-sphinx 1.2.2+dfsg-1ubuntu1, so this should
be OK.
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 802efd98..d18325e2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -10,7 +10,7 @@ addons:
     - libxapian-dev
     - libgmime-2.6-dev
     - libtalloc-dev
-    - python-sphinx
+    - python3-sphinx
     - gdb
     - gpgsm
 
-- 
2.15.1

Re: [PATCH 1/2] INSTALL: refer to python3-sphinx

[David Bremner]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> @@ -88,11 +88,11 @@ dependencies with a simple simple command line. For example:

BTW, "simple simple" is probably a typo  

Re: [PATCH 1/2] INSTALL: refer to python3-sphinx

[Daniel Kahn Gillmor]

On Wed 2018-01-10 13:09:20 -0400, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> @@ -88,11 +88,11 @@ dependencies with a simple simple command line. For example:
>
> BTW, "simple simple" is probably a typo  

but it's so simple, you have to say it twice!

    --dkg

Re: [PATCH 1/2] INSTALL: refer to python3-sphinx

[Tomi Ollila]

On Wed, Jan 10 2018, Daniel Kahn Gillmor wrote:

> We're now preferring to build with python3 instead of python2.  Update
> the INSTALL to match.
>
> Thanks to Antoine Amarilli <a3nm@a3nm.net> for pointing this out!

I agree. LGTM

> ---
>  INSTALL | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index 875014f0..4a0dc741 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -88,11 +88,11 @@ dependencies with a simple simple command line. For example:
>  
>    For Debian and similar:
>  
> -        sudo apt-get install libxapian-dev libgmime-3.0-dev libtalloc-dev zlib1g-dev python-sphinx
> +        sudo apt-get install libxapian-dev libgmime-3.0-dev libtalloc-dev zlib1g-dev python3-sphinx
>  
>    For Fedora and similar:
>  
> -	sudo yum install xapian-core-devel gmime-devel libtalloc-devel zlib-devel python-sphinx
> +	sudo yum install xapian-core-devel gmime-devel libtalloc-devel zlib-devel python3-sphinx
>  
>  On other systems, a similar command can be used, but the details of
>  the package names may be different.
> -- 
> 2.15.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] INSTALL: refer to python3-sphinx

[David Bremner]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> We're now preferring to build with python3 instead of python2.  Update
> the INSTALL to match.

I pushed this series, and replaced "simple simple" with "single simple"

Re: Bug: INSTALL should mention python3-sphinx not python-sphinx

[Daniel Kahn Gillmor]

On Wed 2018-01-10 16:38:18 +0100, Antoine Amarilli wrote:

> In the current master (a727e7d4d398375c4a3ba5020e2ab25b5b874785),
> INSTALL contains:
>
>   For Debian and similar:
>
>         sudo apt-get install libxapian-dev libgmime-3.0-dev libtalloc-dev zlib1g-dev python-sphinx
>
> However it seems like what is currently used is python3-sphinx, cf
> commit 03f4f75124c6d9882b8306873e8908aac9eee2bb. At least on my system,
> when I have just python-sphinx installed instead of python3-sphinx,
> ./configure says it will not build man pages, whereas it works with
> python3-sphinx.
>
> So I think the line above should be changed.

woops, this sounds correct to me.  it would actually have built manpages
if you didn't have python3 installed at all :) but sensible machines do
have python3 these days, so we should be optimizing for those
situations.

> Probably the Fedora line just below needs to be changed too, but I
> don't know how their packaging work (do they have a python3-sphinx
> package or not).

https://developer.fedoraproject.org/tech/languages/python/sphinx.html
suggests that they do have one with the same name.

         --dkg