From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 960EB6DE0FBD for ; Fri, 15 Dec 2017 13:54:17 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.000, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xi0EVkmBxr-i for ; Fri, 15 Dec 2017 13:54:15 -0800 (PST) Received: from mail.gocept.net (mail.gocept.net [195.62.125.19]) by arlo.cworth.org (Postfix) with ESMTPS id 6599E6DE0222 for ; Fri, 15 Dec 2017 13:54:15 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.gocept.net (Postfix) with ESMTP id F002F14C0005; Fri, 15 Dec 2017 22:54:12 +0100 (CET) X-Virus-Scanned: amavisd-new at gocept.net Received: from mail.gocept.net ([127.0.0.1]) by localhost (mail.gocept.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mxlf-MtlNt5e; Fri, 15 Dec 2017 22:54:08 +0100 (CET) Received: from url.lan (2001-44b8-2192-1000-0000-0000-0000-02fe.static.ipv6.internode.on.net [IPv6:2001:44b8:2192:1000::2fe]) (Authenticated sender: roman@bromeco.de) by mail.gocept.net (Postfix) with ESMTPSA; Fri, 15 Dec 2017 22:54:07 +0100 (CET) Date: Sat, 16 Dec 2017 07:54:02 +1000 From: =?utf-8?B?UsOzbWFu?= Joost To: David Bremner Cc: =?utf-8?B?UsOzbWFu?= Joost , notmuch@notmuchmail.org Subject: Re: [PATCH] lib: return "" rather than NULL from notmuch_thread_get_authors Message-ID: <20171215215402.k6dbyyyyjr6l2ibg@url.lan> References: <20171127080602.dmjnxek326bxyv2b@url> <20171215022957.10447-1-david@tethera.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yrr47rpouie3cvab" Content-Disposition: inline In-Reply-To: <20171215022957.10447-1-david@tethera.net> User-Agent: NeoMutt/20170912-24-9dc0ee X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2017 21:54:17 -0000 --yrr47rpouie3cvab Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Dear David, On Thu, Dec 14, 2017 at 10:29:57PM -0400, David Bremner wrote: > The current beheviour is at best underdocumented. The modified test in > T470-missing-headers.sh previously relied on printf doing the right > thing with NULL, which seems ick. >=20 > The use of talloc_strdup here is probably overkill, but it avoids > having to enforce that thread->authors is never mutated outside > _resolve_thread_authors_string. > [...] Thanks a lot for this patch. I think it'll help future authors to be less surprised :)) Kind Regards, --=20 R=C3=B3man Joost email: roman@bromeco.de GPG key: 3A765B52 --yrr47rpouie3cvab Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEE0CvG4JWgRGJn4fQ8ATPQxzp2W1IFAlo0RHoACgkQATPQxzp2 W1KLWwf/RxXaz13Ih0OvWHrW+OBv2kb8HOmyElcCoMbTePhd8LJn2bB+Q0BVl6Hf HGJR1THiEoPYZZ3gFmhdSn+2A5Onj8l/P351hots/8PYE4cMSYAYDvo4I4+pG1Z2 vmahlUbH/J2vdeQ4I5Sh+/TswwGIeBmXGf/+KMSGBdOf8+ye60RKZBVHwsuOBfMR vxZ+ZssUVQFYdD2ou4GgFiMxyVuZKDjcIFoZzDxjtP9HewTJlSA8+IY2nhZKnwZp h9pwFc7ruI5Sq/8sBAJBrAnYRfL0BiHQOCo3DymQimoFdYkf/sUwH6Fngcbfa9c1 2HrWyqsKGhg2vP1G8k5N/ZDn1okuZA== =9P0J -----END PGP SIGNATURE----- --yrr47rpouie3cvab--