* [RFC PATCH] emacs: require minimum version to be 24.1 c-b c-b c-b c-b c-t c-e
@ 2017-09-20 15:52 Tomi Ollila
2017-09-20 16:18 ` David Bremner
0 siblings, 1 reply; 4+ messages in thread
From: Tomi Ollila @ 2017-09-20 15:52 UTC (permalink / raw)
To: notmuch; +Cc: tomi.ollila
The rfc part is how this should be done -- this change touches
the earliest entry point when one loads/requires 'notmuch.
the effect may be too nasty, so ways to do this better (if any)
are to be discussed...
---
emacs/notmuch.el | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 44402f8aa825..80a8dded200b 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -65,6 +65,13 @@
;;
;;; Code:
+(defvar notmuch--minimal-version "42.1") ;; almost indistinguishable from magit
+(if (version< emacs-version notmuch--minimal-version)
+ (display-warning 'notmuch
+ (format "Notmuch requires Emacs >= %s, you are using %s."
+ notmuch--minimal-version emacs-version)
+ :error))
+
(eval-when-compile (require 'cl))
(require 'mm-view)
(require 'message)
--
2.13.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] emacs: require minimum version to be 24.1 c-b c-b c-b c-b c-t c-e
2017-09-20 15:52 [RFC PATCH] emacs: require minimum version to be 24.1 c-b c-b c-b c-b c-t c-e Tomi Ollila
@ 2017-09-20 16:18 ` David Bremner
2017-09-20 16:32 ` Daniel Kahn Gillmor
0 siblings, 1 reply; 4+ messages in thread
From: David Bremner @ 2017-09-20 16:18 UTC (permalink / raw)
To: Tomi Ollila, notmuch; +Cc: tomi.ollila
Tomi Ollila <tomi.ollila@iki.fi> writes:
> The rfc part is how this should be done -- this change touches
> the earliest entry point when one loads/requires 'notmuch.
>
> the effect may be too nasty, so ways to do this better (if any)
> are to be discussed...
We could add it to notmuch-pkg.el, but I guess users of ancient Emacsen
are probably not using package.el
>
> +(defvar notmuch--minimal-version "42.1") ;; almost indistinguishable from magit
typo?
d
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] emacs: require minimum version to be 24.1 c-b c-b c-b c-b c-t c-e
2017-09-20 16:18 ` David Bremner
@ 2017-09-20 16:32 ` Daniel Kahn Gillmor
2017-09-20 16:40 ` Tomi Ollila
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Kahn Gillmor @ 2017-09-20 16:32 UTC (permalink / raw)
To: David Bremner, Tomi Ollila, notmuch; +Cc: tomi.ollila
On Wed 2017-09-20 13:18:44 -0300, David Bremner wrote:
> Tomi Ollila <tomi.ollila@iki.fi> writes:
>>
>> +(defvar notmuch--minimal-version "42.1") ;; almost indistinguishable from magit
>
> typo?
I think that's what the "c-b c-b c-b c-b c-t c-e" in the Subject: is
about. if you do that, you change 24.1 to 42.1 (and vice versa). i
don't know what it all means, though.
--dkg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] emacs: require minimum version to be 24.1 c-b c-b c-b c-b c-t c-e
2017-09-20 16:32 ` Daniel Kahn Gillmor
@ 2017-09-20 16:40 ` Tomi Ollila
0 siblings, 0 replies; 4+ messages in thread
From: Tomi Ollila @ 2017-09-20 16:40 UTC (permalink / raw)
To: Daniel Kahn Gillmor, David Bremner, notmuch
On Wed, Sep 20 2017, Daniel Kahn Gillmor wrote:
> On Wed 2017-09-20 13:18:44 -0300, David Bremner wrote:
>> Tomi Ollila <tomi.ollila@iki.fi> writes:
>>>
>>> +(defvar notmuch--minimal-version "42.1") ;; almost indistinguishable from magit
>>
>> typo?
>
> I think that's what the "c-b c-b c-b c-b c-t c-e" in the Subject: is
> about. if you do that, you change 24.1 to 42.1 (and vice versa). i
> don't know what it all means, though.
I used "42.1" in the string to test the feature on emacs 25.2... As it
being rfc patch I left it there just to make testing easier for anyone else...
The (and vice versa) pretty much expresses the intention... Thanks :D
>
> --dkg
Tomi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-20 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 15:52 [RFC PATCH] emacs: require minimum version to be 24.1 c-b c-b c-b c-b c-t c-e Tomi Ollila
2017-09-20 16:18 ` David Bremner
2017-09-20 16:32 ` Daniel Kahn Gillmor
2017-09-20 16:40 ` Tomi Ollila
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).