From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 680E46DE009B for ; Sun, 27 Aug 2017 16:58:37 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JzdMJIeoNLsH for ; Sun, 27 Aug 2017 16:58:36 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id E27E66DE012F for ; Sun, 27 Aug 2017 16:58:34 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1dm7OL-000524-Sp; Sun, 27 Aug 2017 19:54:57 -0400 Received: (nullmailer pid 27225 invoked by uid 1000); Sun, 27 Aug 2017 23:58:29 -0000 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: [PATCH 3/5] test: known broken test for subject after reindexing Date: Sun, 27 Aug 2017 20:58:21 -0300 Message-Id: <20170827235823.27177-3-david@tethera.net> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170827235823.27177-1-david@tethera.net> References: <1503859703-2973-1-git-send-email-markwalters1009@gmail.com> <20170827235823.27177-1-david@tethera.net> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Aug 2017 23:58:37 -0000 In [1], Mark gave a test that was behaving strangly. This turns out to be specific to reindexing. I suppose one could argue that picking the lexicographically last file name is a defensible choice, but it's almost as easy to take the first, which seems more intuitive. So mark the current situation as broken. [1]: id:1503859703-2973-1-git-send-email-markwalters1009@gmail.com --- test/T670-duplicate-mid.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/T670-duplicate-mid.sh b/test/T670-duplicate-mid.sh index d2f89432..d4c1d1c2 100755 --- a/test/T670-duplicate-mid.sh +++ b/test/T670-duplicate-mid.sh @@ -40,6 +40,14 @@ notmuch reindex '*' notmuch search --output=files "sekrit" | notmuch_dir_sanitize > OUTPUT test_expect_equal_file EXPECTED OUTPUT +test_begin_subtest 'reindex choses subject from first filename' +test_subtest_known_broken +cat < EXPECTED +thread:XXX 2001-01-05 [1/1(3)] Notmuch Test Suite; message 0 (inbox unread) +EOF +notmuch search id:duplicate | notmuch_search_sanitize > OUTPUT +test_expect_equal_file EXPECTED OUTPUT + rm ${MAIL_DIR}/copy0 test_begin_subtest 'Deleted first duplicate file does not stop notmuch show from working' output=$(notmuch show --body=false --format=json id:duplicate | -- 2.13.2