unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Florian Klink <flokli@flokli.de>
To: Gaute Hope <eg@gaute.vetsj.com>
Cc: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] python: open messages in binary mode
Date: Fri, 25 Aug 2017 12:18:09 +0200	[thread overview]
Message-ID: <20170825101809.wb7xejdxxiqrsg2z@tp.flokli.de> (raw)
In-Reply-To: <1503641077.7gk2974n4k.astroid@strange.none>

>>that function is only since python 3.2. I'm not sure if/when we'll drop
>>python 2.7 support, but not without deprecating it for a few releases.

>Is there anyone still exclusively on Python 2.7? Perhaps the time is 
>ripe for starting that process? Encoding compatability is an unholy 
>mess to maintain for one Python distro.

If Python 2 doesn't have email.message_from_binary_file(), it might be the bug
occuring to be can't really be fixed in Python 2 anyways. Maybe it's possible to
open the file in binary mode on Python 2, and pass this to
email.message_from_file() though, I will tinker around a bit this evening, and
let you know. 

>Is any of alot, afew, etc still on Python 2 only?

afew works on both Python 2 and 3
alot seems to currently be Python 2 only (at least the Travis runs are), but it
looks like they are thinking about moving to Python 3 and dropping Python 2:
https://github.com/pazz/alot/issues/1047#issuecomment-300713819

Florian

  reply	other threads:[~2017-08-25 10:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 21:30 [PATCH] python: open messages in binary mode Florian Klink
2017-08-24 22:11 ` David Bremner
2017-08-25  6:08   ` Gaute Hope
2017-08-25 10:18     ` Florian Klink [this message]
2017-09-24 12:36   ` [PATCH v2 1/2] " Florian Klink
2017-09-24 12:36     ` [PATCH v2 2/2] T390-python: add test for get_message_parts and special characters Florian Klink
2017-10-02 11:04     ` [PATCH v2 1/2] python: open messages in binary mode David Bremner
2017-10-02 11:39       ` Florian Klink
2017-10-05 15:50         ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825101809.wb7xejdxxiqrsg2z@tp.flokli.de \
    --to=flokli@flokli.de \
    --cc=david@tethera.net \
    --cc=eg@gaute.vetsj.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).