From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A94106DE12C2 for ; Tue, 22 Aug 2017 15:44:12 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.026 X-Spam-Level: X-Spam-Status: No, score=0.026 tagged_above=-999 required=5 tests=[AWL=-0.204, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XzGQKNRLba1r for ; Tue, 22 Aug 2017 15:44:11 -0700 (PDT) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id 084806DE1202 for ; Tue, 22 Aug 2017 15:44:11 -0700 (PDT) Received: by mail-wm0-f68.google.com with SMTP id r77so532086wmd.2 for ; Tue, 22 Aug 2017 15:44:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yoIe8rwo+h2wuooxLPHP8Y2gvMrRP3hlDTlRm5YS4/w=; b=iTpGP0iEJvgjIgMLHp4XX5CGopYleEAFdu/p6IhNrZdasynF5T3QcBiBSplOi4lNJ4 yrlbaS3TkYaMUayPnUjtmA0eW7DL+WUejsgHQBMrmFCjoclvPTTkZ9h/VoWdadZlm3kV AD5/BZ6vzuAEOsR/t5NmMR5DwDetBw3e1HDB8hMp37izviX+pfrKVhAAvo7v8Nl0IaqS 8/iB5kkAldwIHzGy4qA/kBMyGbakwdOVY369o2/c9OuZgFC0KaidJ4fylmF/HyXAdkag EzEekfQmXYsQnPkTh8qWyXGnxk+O3ZKi0++miF52fgSIYKYA6POuuO0Iw+YGBqfiX9uw 7S8Q== X-Gm-Message-State: AHYfb5i4DUjDqonVZI+idthkdUum67w8O2vpKc/sdotKSnGny8WtZ2Fc c/2o8CgaXuKhJiD1i3w= X-Received: by 10.28.193.8 with SMTP id r8mr524366wmf.170.1503441849247; Tue, 22 Aug 2017 15:44:09 -0700 (PDT) Received: from home.thecybershadow.net ([89.28.117.31]) by smtp.gmail.com with ESMTPSA id e137sm491385wma.29.2017.08.22.15.44.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Aug 2017 15:44:08 -0700 (PDT) From: Vladimir Panteleev To: notmuch@notmuchmail.org Cc: Vladimir Panteleev Subject: [PATCH 1/8] lib: Fix talloc not being defined on Cygwin Date: Tue, 22 Aug 2017 22:43:32 +0000 Message-Id: <20170822224339.22601-2-notmuch@thecybershadow.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170822224339.22601-1-notmuch@thecybershadow.net> References: <20170822224339.22601-1-notmuch@thecybershadow.net> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 22:44:12 -0000 From: Vladimir Panteleev With GNU libc, talloc will not be declared unless _GNU_SOURCE is defined before including stdio.h. Although this is done in notmuch-private.h, that file is included after including inttypes.h in database-private.h. On Cygwin, this apparently leads to including the header file containing the talloc declaration (before _GNU_SOURCE is defined), thus causing the notmuch compilation to fail. * database-private.h: Include notmuch-private.h before including inttypes.h. --- lib/database-private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/database-private.h b/lib/database-private.h index 5555554b..117211c7 100644 --- a/lib/database-private.h +++ b/lib/database-private.h @@ -21,6 +21,8 @@ #ifndef NOTMUCH_DATABASE_PRIVATE_H #define NOTMUCH_DATABASE_PRIVATE_H +#include "notmuch-private.h" + /* According to WG14/N1124, a C++ implementation won't provide us a * macro like PRIx64 (which gives a printf format string for * formatting a uint64_t as hexadecimal) unless we define @@ -30,8 +32,6 @@ #define __STDC_FORMAT_MACROS #include -#include "notmuch-private.h" - #ifdef SILENCE_XAPIAN_DEPRECATION_WARNINGS #define XAPIAN_DEPRECATED(D) D #endif -- 2.13.3