From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id E96BB6DE098B for ; Fri, 4 Aug 2017 14:38:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.006 X-Spam-Level: X-Spam-Status: No, score=0.006 tagged_above=-999 required=5 tests=[AWL=0.005, HEADER_FROM_DIFFERENT_DOMAINS=0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kroHVPqRpK_5 for ; Fri, 4 Aug 2017 14:38:53 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id B2DEC6DE0962 for ; Fri, 4 Aug 2017 14:38:53 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1ddkFh-0007Ie-HV; Fri, 04 Aug 2017 17:35:25 -0400 Received: (nullmailer pid 18973 invoked by uid 1000); Fri, 04 Aug 2017 21:38:51 -0000 From: David Bremner To: notmuch@notmuchmail.org, notmuch@freelists.org Subject: [PATCH] test: add broken tests for maildir syncing Date: Fri, 4 Aug 2017 17:38:45 -0400 Message-Id: <20170804213845.18902-1-david@tethera.net> X-Mailer: git-send-email 2.13.2 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 21:38:55 -0000 Users should be able to specify synced tags in new.tags --- Anarcat had an interesting idea about using "flagged" in new.tags, but it doesn't work, because of (I think) the following code: for (tag = state->new_tags; *tag != NULL; tag++) notmuch_message_add_tag (message, *tag); if (state->synchronize_flags) notmuch_message_maildir_flags_to_tags (message); i.e. the tags are removed because the newly delivered message doesn't have them. FWIW, notmuch-insert does the right thing, I think test/T340-maildir-sync.sh | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/test/T340-maildir-sync.sh b/test/T340-maildir-sync.sh index 959bf8d8..172c22eb 100755 --- a/test/T340-maildir-sync.sh +++ b/test/T340-maildir-sync.sh @@ -181,11 +181,33 @@ test_expect_equal "$(cd $MAIL_DIR/cur/; ls non-compliant*)" "non-compliant-maild test_begin_subtest "Files in new/ get default synchronized tags" OLDCONFIG=$(notmuch config get new.tags) -notmuch config set new.tags test +notmuch config set new.tags test;unread add_message [subject]='"File in new/"' [dir]=new [filename]='file-in-new' notmuch config set new.tags $OLDCONFIG notmuch search 'subject:"File in new"' | notmuch_search_sanitize > output test_expect_equal "$(< output)" \ "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; File in new/ (test unread)" +test_begin_subtest "unread is not mandatory in new/" +test_subtest_known_broken +OLDCONFIG=$(notmuch config get new.tags) +notmuch config set new.tags test +add_message [subject]='"File in new/"' [dir]=new [filename]='file-in-new' +notmuch config set new.tags $OLDCONFIG +notmuch search 'subject:"File in new"' | notmuch_search_sanitize > output +test_expect_equal "$(< output)" \ +"thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; File in new/ (test)" + +for tag in draft flagged passed replied; do + + test_begin_subtest "$tag is valid in new.tags" + test_subtest_known_broken + OLDCONFIG=$(notmuch config get new.tags) + notmuch config set new.tags "$tag" + add_message [subject]="\"$tag sync in new\"" [dir]=new + notmuch config set new.tags $OLDCONFIG + notmuch search subject:"$tag in new" | notmuch_search_sanitize > output + test_expect_equal "$(< output)" \ + "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; $tag sync in new ($tag)" +done test_done -- 2.13.2