From: Piotr Trojanek <piotr.trojanek@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 5/5] flag potential problems with FIXME
Date: Fri, 16 Jun 2017 23:50:26 +0100 [thread overview]
Message-ID: <20170616225026.8098-5-piotr.trojanek@gmail.com> (raw)
In-Reply-To: <20170616225026.8098-1-piotr.trojanek@gmail.com>
Detected by cppcheck.
---
lib/directory.cc | 1 +
lib/string-map.c | 1 +
2 files changed, 2 insertions(+)
diff --git lib/directory.cc lib/directory.cc
index 5de3319c..801f1e5b 100644
--- lib/directory.cc
+++ lib/directory.cc
@@ -302,6 +302,7 @@ notmuch_directory_delete (notmuch_directory_t *directory)
"A Xapian exception occurred deleting directory entry: %s.\n",
error.get_msg().c_str());
directory->notmuch->exception_reported = TRUE;
+ /* FIXME: Variable 'status' is assigned a value that is never used. */
status = NOTMUCH_STATUS_XAPIAN_EXCEPTION;
}
notmuch_directory_destroy (directory);
diff --git lib/string-map.c lib/string-map.c
index 0bb77e93..11c0a644 100644
--- lib/string-map.c
+++ lib/string-map.c
@@ -122,6 +122,7 @@ bsearch_first (notmuch_string_pair_t *array, size_t len, const char *key, notmuc
size_t last = len - 1;
size_t mid;
+ /* FIXME: Checking if unsigned variable 'len' is less than zero. */
if (len <= 0)
return NULL;
--
2.11.0
next prev parent reply other threads:[~2017-06-16 22:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 22:50 [PATCH 1/5] minor whitespace cleanups Piotr Trojanek
2017-06-16 22:50 ` [PATCH 2/5] add leaks due to missing invocations of va_end Piotr Trojanek
2017-06-16 22:50 ` [PATCH 3/5] remove ineffective assignments Piotr Trojanek
2017-08-20 13:56 ` Jani Nikula
2017-06-16 22:50 ` [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers Piotr Trojanek
2017-06-21 16:11 ` Daniel Kahn Gillmor
2017-06-26 12:14 ` Piotr Trojanek
2017-06-26 13:04 ` David Bremner
2017-06-26 22:54 ` David Bremner
2017-06-25 12:57 ` David Bremner
2017-06-16 22:50 ` Piotr Trojanek [this message]
2017-06-25 12:34 ` [PATCH 1/5] minor whitespace cleanups David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616225026.8098-5-piotr.trojanek@gmail.com \
--to=piotr.trojanek@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).