From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wiz@danbala.ifoer.tuwien.ac.at>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 26FD46DE0AAA
 for <notmuch@notmuchmail.org>; Sun, 14 May 2017 03:08:21 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 1.33
X-Spam-Level: *
X-Spam-Status: No, score=1.33 tagged_above=-999 required=5 tests=[AWL=-0.361, 
 HEADER_FROM_DIFFERENT_DOMAINS=0.001, T_RP_MATCHES_RCVD=-0.01,
 URIBL_BLACK=1.7] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 0BNlpWc5WM5u for <notmuch@notmuchmail.org>;
 Sun, 14 May 2017 03:08:11 -0700 (PDT)
Received: from danbala.ifoer.tuwien.ac.at (danbala.ifoer.tuwien.ac.at
 [128.130.168.114])
 by arlo.cworth.org (Postfix) with ESMTPS id B4A7D6DE0931
 for <notmuch@notmuchmail.org>; Sun, 14 May 2017 03:08:11 -0700 (PDT)
Received: by danbala.ifoer.tuwien.ac.at (Postfix, from userid 116)
 id CE25EA522; Sun, 14 May 2017 12:08:07 +0200 (CEST)
Date: Sun, 14 May 2017 12:08:07 +0200
From: Thomas Klausner <tk@giga.or.at>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org, Jonathan Perkin <jperkin@NetBSD.org>,
 notmuch@freelists.org
Subject: Re: notmuch-0.24.1: missing header include
Message-ID: <20170514100807.nlsgkxsfh2ndprky@danbala>
References: <20170420093944.xpkczqnztv4nwx7p@danbala>
 <sfid-+20170514-013535-+018.14-1@spamfilter.osbf.lua>
 <87fug8z7tc.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87fug8z7tc.fsf@tethera.net>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 14 May 2017 10:08:21 -0000

On Sat, May 13, 2017 at 07:54:39PM -0300, David Bremner wrote:
> > On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
> > uses index(3) but does not include strings.h.
> >
> > Please apply the attached patch or a similar one.
> >
> > Thanks,
> >  Thomas
> 
> In master we've replaced index(3) with strchr(3). Does that fix your
> issue, or is the include still needed?

Since you already include <string.h> that's fine.

Thanks,
 Thomas