unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Thomas Klausner <tk@giga.or.at>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org, Jonathan Perkin <jperkin@NetBSD.org>,
	notmuch@freelists.org
Subject: Re: notmuch-0.24.1: missing header include
Date: Sun, 14 May 2017 12:08:07 +0200	[thread overview]
Message-ID: <20170514100807.nlsgkxsfh2ndprky@danbala> (raw)
In-Reply-To: <87fug8z7tc.fsf@tethera.net>

On Sat, May 13, 2017 at 07:54:39PM -0300, David Bremner wrote:
> > On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
> > uses index(3) but does not include strings.h.
> >
> > Please apply the attached patch or a similar one.
> >
> > Thanks,
> >  Thomas
> 
> In master we've replaced index(3) with strchr(3). Does that fix your
> issue, or is the include still needed?

Since you already include <string.h> that's fine.

Thanks,
 Thomas

      reply	other threads:[~2017-05-14 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20  9:47 notmuch-0.24.1: missing header include Thomas Klausner
2017-05-13 22:54 ` David Bremner
2017-05-14 10:08   ` Thomas Klausner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170514100807.nlsgkxsfh2ndprky@danbala \
    --to=tk@giga.or.at \
    --cc=david@tethera.net \
    --cc=jperkin@NetBSD.org \
    --cc=notmuch@freelists.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).