notmuch-0.24.1: missing header include

notmuch-0.24.1: missing header include

[Thomas Klausner]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Hi!

On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
uses index(3) but does not include strings.h.

Please apply the attached patch or a similar one.

Thanks,
 Thomas

[-- Attachment #2: patch-lib_notmuch-private.h --]
[-- Type: text/plain, Size: 392 bytes --]

$NetBSD: patch-lib_notmuch-private.h,v 1.1 2017/04/20 09:06:34 jperkin Exp $

Include strings.h for index(3).

--- lib/notmuch-private.h.orig	2017-04-01 12:29:38.000000000 +0000
+++ lib/notmuch-private.h
@@ -38,6 +38,7 @@ NOTMUCH_BEGIN_DECLS
 #include <sys/stat.h>
 #include <sys/mman.h>
 #include <string.h>
+#include <strings.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <unistd.h>

Re: notmuch-0.24.1: missing header include

[David Bremner]

Thomas Klausner <tk@giga.or.at> writes:

> Hi!
>
> On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
> uses index(3) but does not include strings.h.
>
> Please apply the attached patch or a similar one.
>
> Thanks,
>  Thomas

In master we've replaced index(3) with strchr(3). Does that fix your
issue, or is the include still needed?

d

Re: notmuch-0.24.1: missing header include

[Thomas Klausner]

On Sat, May 13, 2017 at 07:54:39PM -0300, David Bremner wrote:
> > On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
> > uses index(3) but does not include strings.h.
> >
> > Please apply the attached patch or a similar one.
> >
> > Thanks,
> >  Thomas
> 
> In master we've replaced index(3) with strchr(3). Does that fix your
> issue, or is the include still needed?

Since you already include <string.h> that's fine.

Thanks,
 Thomas