From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [PATCH 6/8] lib: propagate errors from nme_metadata through properties API
Date: Sat, 18 Feb 2017 10:45:49 -0400 [thread overview]
Message-ID: <20170218144551.22925-7-david@tethera.net> (raw)
In-Reply-To: <20170218144551.22925-1-david@tethera.net>
The NULL return here is not API breaking, since the NULL from
_string_map_create could previously be returned.
---
lib/message-private.h | 4 ++--
lib/message-property.cc | 17 +++++++++++++++--
lib/message.cc | 28 ++++++++++++++++++++--------
lib/notmuch.h | 6 ++++--
4 files changed, 41 insertions(+), 14 deletions(-)
diff --git a/lib/message-private.h b/lib/message-private.h
index 74199256..2cfc95a7 100644
--- a/lib/message-private.h
+++ b/lib/message-private.h
@@ -1,8 +1,8 @@
#ifndef MESSAGE_PRIVATE_H
#define MESSAGE_PRIVATE_H
-notmuch_string_map_t *
-_notmuch_message_property_map (notmuch_message_t *message);
+notmuch_private_status_t
+_notmuch_message_property_map (notmuch_message_t *message, notmuch_string_map_t **map);
notmuch_bool_t
_notmuch_message_frozen (notmuch_message_t *message);
diff --git a/lib/message-property.cc b/lib/message-property.cc
index 0b13cac3..e81843d3 100644
--- a/lib/message-property.cc
+++ b/lib/message-property.cc
@@ -28,10 +28,18 @@
notmuch_status_t
notmuch_message_get_property (notmuch_message_t *message, const char *key, const char **value)
{
+ notmuch_private_status_t private_status;
+ notmuch_string_map_t *map;
+
if (! value)
return NOTMUCH_STATUS_NULL_POINTER;
- *value = _notmuch_string_map_get (_notmuch_message_property_map (message), key);
+ private_status = _notmuch_message_property_map (message, &map);
+ if (private_status)
+ return COERCE_STATUS (private_status,
+ "Unhandled error reading message property");
+
+ *value = _notmuch_string_map_get (map, key);
return NOTMUCH_STATUS_SUCCESS;
}
@@ -110,8 +118,13 @@ notmuch_message_remove_all_properties (notmuch_message_t *message, const char *k
notmuch_message_properties_t *
notmuch_message_get_properties (notmuch_message_t *message, const char *key, notmuch_bool_t exact)
{
+ notmuch_private_status_t private_status;
notmuch_string_map_t *map;
- map = _notmuch_message_property_map (message);
+
+ private_status = _notmuch_message_property_map (message, &map);
+ if (private_status)
+ return NULL;
+
return _notmuch_string_map_iterator_create (map, key, exact);
}
diff --git a/lib/message.cc b/lib/message.cc
index 80fbd5ab..9ba24e8c 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -1823,16 +1823,19 @@ _notmuch_message_database (notmuch_message_t *message)
return message->notmuch;
}
-static void
+static notmuch_private_status_t
_notmuch_message_ensure_property_map (notmuch_message_t *message)
{
notmuch_string_node_t *node;
if (message->property_map)
- return;
+ return NOTMUCH_PRIVATE_STATUS_SUCCESS;
- if (!message->property_term_list)
- _notmuch_message_ensure_metadata (message);
+ if (!message->property_term_list) {
+ notmuch_private_status_t status = _notmuch_message_ensure_metadata (message);
+ if (status)
+ return status;
+ }
message->property_map = _notmuch_string_map_create (message);
@@ -1854,14 +1857,23 @@ _notmuch_message_ensure_property_map (notmuch_message_t *message)
talloc_free (message->property_term_list);
message->property_term_list = NULL;
+ return NOTMUCH_PRIVATE_STATUS_SUCCESS;
}
-notmuch_string_map_t *
-_notmuch_message_property_map (notmuch_message_t *message)
+notmuch_private_status_t
+_notmuch_message_property_map (notmuch_message_t *message, notmuch_string_map_t **map)
{
- _notmuch_message_ensure_property_map (message);
+ notmuch_private_status_t status;
+
+ if (!map)
+ return NOTMUCH_PRIVATE_STATUS_NULL_POINTER;
- return message->property_map;
+ status = _notmuch_message_ensure_property_map (message);
+ if (status)
+ return status;
+
+ *map = message->property_map;
+ return NOTMUCH_PRIVATE_STATUS_SUCCESS;
}
notmuch_bool_t
diff --git a/lib/notmuch.h b/lib/notmuch.h
index 4e25958c..2e8ccb05 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -1753,7 +1753,7 @@ typedef struct _notmuch_string_map_iterator notmuch_message_properties_t;
* notmuch_message_properties_t *list;
*
* for (list = notmuch_message_get_properties (message, "testkey1", TRUE);
- * notmuch_message_properties_valid (list); notmuch_message_properties_move_to_next (list)) {
+ * list && notmuch_message_properties_valid (list); notmuch_message_properties_move_to_next (list)) {
* printf("%s\n", notmuch_message_properties_value(list));
* }
*
@@ -1761,9 +1761,11 @@ typedef struct _notmuch_string_map_iterator notmuch_message_properties_t;
*
* Note that there's no explicit destructor needed for the
* notmuch_message_properties_t object. (For consistency, we do
- * provide a notmuch_message_properities_destroy function, but there's
+ * provide a notmuch_message_properties_destroy function, but there's
* no good reason to call it if the message is about to be destroyed).
*
+ * @return The function returns NULL on error
+ *
* @since libnotmuch 4.4 (notmuch 0.23)
*/
notmuch_message_properties_t *
--
2.11.0
next prev parent reply other threads:[~2017-02-18 14:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 14:45 add status value to _notmuch_message_ensure_metadata David Bremner
2017-02-18 14:45 ` [PATCH 1/8] lib: make _notmuch_message_ensure_metadata static David Bremner
2017-02-23 12:59 ` David Bremner
2017-02-18 14:45 ` [PATCH 2/8] lib: add status return to _notmuch_message_ensure_metadata David Bremner
2017-02-18 14:45 ` [PATCH 3/8] lib: propagate error return from some calls to _n_m_e_metadata David Bremner
2017-02-18 14:45 ` [PATCH 4/8] lib: push error from nme_metadata through nme_filename_list David Bremner
2017-02-18 14:45 ` [PATCH 5/8] lib: make _notmuch_message_ensure_property_map static David Bremner
2017-02-18 14:45 ` David Bremner [this message]
2017-02-18 14:45 ` [PATCH 7/8] lib: add notmuch_message_get_database to public API David Bremner
2017-02-18 14:45 ` [PATCH 8/8] lib: add status return to notmuch_message_get_flag David Bremner
2017-02-20 9:27 ` add status value to _notmuch_message_ensure_metadata Gaute Hope
2017-02-20 9:44 ` Gaute Hope
2017-02-23 0:58 ` David Bremner
2017-02-23 7:46 ` Gaute Hope
2017-02-23 11:59 ` David Bremner
2017-02-24 2:00 ` [RFC patch 1/2] lib: add notmuch_database_reopen David Bremner
2017-02-24 2:00 ` [RFC patch 2/2] lib: handle DatabaseModifiedError in _n_message_ensure_metadata David Bremner
2017-02-24 2:49 ` David Bremner
2017-02-24 10:21 ` Gaute Hope
2017-02-24 11:40 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170218144551.22925-7-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).