From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 0F3F26DE00AC for ; Sun, 13 Nov 2016 05:03:33 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.006 X-Spam-Level: X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5 tests=[AWL=0.005, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XhgiJYmm_WTH for ; Sun, 13 Nov 2016 05:03:32 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 1F1D56DE0008 for ; Sun, 13 Nov 2016 05:03:31 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1c5uRA-0006O1-3V; Sun, 13 Nov 2016 08:03:08 -0500 Received: (nullmailer pid 12353 invoked by uid 1000); Sun, 13 Nov 2016 13:03:25 -0000 From: David Bremner To: Tomi Ollila , David Bremner , notmuch@notmuchmail.org Subject: [PATCH] emacs: rename notmuch-address-completion-hook to notmuch-address-post-completion-functions Date: Sun, 13 Nov 2016 09:03:12 -0400 Message-Id: <20161113130312.12309-1-david@tethera.net> X-Mailer: git-send-email 2.10.2 In-Reply-To: References: X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Nov 2016 13:03:33 -0000 Apparently it is a (not completely adhered to) emacs convention [1] that only hooks that don't take arguments end in 'hook' [1]: https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html --- emacs/notmuch-address.el | 4 ++-- emacs/notmuch-company.el | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el index 36c796f..5b2beef 100644 --- a/emacs/notmuch-address.el +++ b/emacs/notmuch-address.el @@ -98,7 +98,7 @@ to know how address selection is made by default." :group 'notmuch-send :group 'notmuch-external) -(defcustom notmuch-address-completion-hook nil +(defcustom notmuch-address-post-completion-functions nil "Functions called after completing address. The completed address is passed as an argument to each function. @@ -218,7 +218,7 @@ external commands." (push chosen notmuch-address-history) (delete-region beg end) (insert chosen) - (run-hook-with-args 'notmuch-address-completion-hook chosen)) + (run-hook-with-args 'notmuch-address-post-completion-functions chosen)) (message "No matches.") (ding)))) (t nil))) diff --git a/emacs/notmuch-company.el b/emacs/notmuch-company.el index 91c4804..b0f9782 100644 --- a/emacs/notmuch-company.el +++ b/emacs/notmuch-company.el @@ -86,7 +86,7 @@ (match (if (string-match notmuch-company-last-prefix arg) (match-end 0) 0)) - (post-completion (run-hook-with-args 'notmuch-address-completion-hook arg)) + (post-completion (run-hook-with-args 'notmuch-address-post-completion-functions arg)) (no-cache t)))) -- 2.10.2