unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* Fix count/search query destructiveness
@ 2016-09-05 15:48 David Bremner
  2016-09-05 15:48 ` [PATCH 1/5] lib: eagerly parse queries David Bremner
                   ` (5 more replies)
  0 siblings, 6 replies; 10+ messages in thread
From: David Bremner @ 2016-09-05 15:48 UTC (permalink / raw)
  To: notmuch

As discussed in id:147263183913.27784.12274024193186585889@mbp, the
current behaviour is destructive due to exclude handling. This makes
some natural code, including notmuch-reply, buggy.

I haven't updated the library prototypes for const correctness, but
that would probably make sense. Before I go through that, I wanted to
get some feedback on the breaking change to
notmuch_query_add_tag_exclude.  Another option would be to add a (take
a breath) notmuch_query_add_tag_exclude_st and wrap that in
notmuch_query_add_tag_exclude. I decided not to go that route in this
initial series since effectively code calling the function as void
impliment this same status ignoring. It depends how terrible we think
bumping the SONAME is. [1]

[1]: If we're going to break the ABI, I'd like to do it soon to give
     Debian a chance to do a transition before the next stable release.q

^ permalink raw reply	[flat|nested] 10+ messages in thread
* V2 non-destructive excludes 
@ 2016-10-02  2:13 David Bremner
  2016-10-02  2:13 ` [PATCH 4/5] lib: query make exclude handling non-destructive David Bremner
  0 siblings, 1 reply; 10+ messages in thread
From: David Bremner @ 2016-10-02  2:13 UTC (permalink / raw)
  To: notmuch

This mainly rebases against master, and fixes the two minor problems
already pointed out.

I would like feedback on breaking the API for this.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2016-10-02  2:13 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-05 15:48 Fix count/search query destructiveness David Bremner
2016-09-05 15:48 ` [PATCH 1/5] lib: eagerly parse queries David Bremner
2016-09-05 15:48 ` [PATCH 2/5] lib/query: make query parsing lazy again, keep centralized David Bremner
2016-09-05 15:48 ` [PATCH 3/5] test: add known broken test for nondestructiveness of count David Bremner
2016-09-05 15:48 ` [PATCH 4/5] lib: query make exclude handling non-destructive David Bremner
2016-09-06 10:39   ` David Bremner
2016-09-05 15:48 ` [PATCH 5/5] lib: make notmuch_query_add_tag_exclude return a status value David Bremner
2016-09-06 11:20   ` David Bremner
2016-09-06 10:37 ` Fix count/search query destructiveness David Bremner
  -- strict thread matches above, loose matches on Subject: below --
2016-10-02  2:13 V2 non-destructive excludes David Bremner
2016-10-02  2:13 ` [PATCH 4/5] lib: query make exclude handling non-destructive David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).