From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id B4F426DE02AF for ; Tue, 30 Aug 2016 01:52:09 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -2.305 X-Spam-Level: X-Spam-Status: No, score=-2.305 tagged_above=-999 required=5 tests=[AWL=0.005, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xa4Nlas8k-E3 for ; Tue, 30 Aug 2016 01:52:08 -0700 (PDT) Received: from hylle05.itea.ntnu.no (hylle05.itea.ntnu.no [129.241.56.225]) by arlo.cworth.org (Postfix) with ESMTPS id 521ED6DE0130 for ; Tue, 30 Aug 2016 01:52:08 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by hylle05.itea.ntnu.no (Postfix) with ESMTP id 7EE4490310C; Tue, 30 Aug 2016 10:52:01 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hylle05.itea.ntnu.no Received: from localhost (unknown [IPv6:2001:700:300:1470:36e6:d7ff:fe81:3aa0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: erikryb) by hylle05.itea.ntnu.no (Postfix) with ESMTPSA id 4F02A910031; Tue, 30 Aug 2016 10:49:16 +0200 (CEST) Date: Tue, 30 Aug 2016 10:49:11 +0200 From: Erik Rybakken To: Tomi Ollila Cc: Jani Nikula , notmuch@notmuchmail.org, David Bremner Subject: Re: [PATCH] Add option `hooks.path` for setting the directory of hooks. Message-ID: <20160830084911.4gkpjpzca5jkkcwy@dell> References: <20160824163006.dzdvzjvkg5uxtrnh@dell> <87vayqnjr3.fsf@nikula.org> <20160824215430.ljugc3vevx4ve2gq@dell> <20160827132543.xlqxwu5owhc5x546@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-07-23) X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 08:52:09 -0000 On Tue, Aug 30, 2016 at 08:43:20AM +0300, Tomi Ollila wrote: > The code looked pretty good -- when did I git am to the email content > I got all from the beginning of this email to the commit message -- > so before next patches use git-format-patch and git-am... Check > > https://notmuchmail.org/contributing/ for more information... Sorry about that. I will start checking my email patches. > 2 things that came up after quick view > > 1) there is one indentation mismatch ;/ I'm not sure what you refer to here. Could you point me to it? > 3) I don't see any calls to notmuch_config_set_hooks_path() Yes, that's true. The function is not needed now, but I kept it for completeness. So, there are only two places in the code where there are calls to notmuch_config_set_*. One of them are in the procedure "notmuch_config_open" in notmuch-config.c where the config file is read. For hooks_path the reading is done differently as explained in the last email. The other place is in notmuch-setup.c, but the notmuch setup does not (for now) set hooks.path. The command "notmuch config set" does not use notmuch_config_set for some reason, but changes the key file directly. - Erik