From: Erik Rybakken <erik.rybakken@math.ntnu.no>
To: Tomi Ollila <tomi.ollila@iki.fi>
Cc: Jani Nikula <jani@nikula.org>,
notmuch@notmuchmail.org, David Bremner <david@tethera.net>
Subject: Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.
Date: Tue, 30 Aug 2016 10:49:11 +0200 [thread overview]
Message-ID: <20160830084911.4gkpjpzca5jkkcwy@dell> (raw)
In-Reply-To: <m2wpiyerrb.fsf@guru.guru-group.fi>
On Tue, Aug 30, 2016 at 08:43:20AM +0300, Tomi Ollila wrote:
> The code looked pretty good -- when did I git am to the email content
> I got all from the beginning of this email to the commit message --
> so before next patches use git-format-patch and git-am... Check
>
> https://notmuchmail.org/contributing/ for more information...
Sorry about that. I will start checking my email patches.
> 2 things that came up after quick view
>
> 1) there is one indentation mismatch ;/
I'm not sure what you refer to here. Could you point me to it?
> 3) I don't see any calls to notmuch_config_set_hooks_path()
Yes, that's true. The function is not needed now, but I kept it for
completeness.
So, there are only two places in the code where there are calls to
notmuch_config_set_*. One of them are in the procedure
"notmuch_config_open" in notmuch-config.c where the config file is read.
For hooks_path the reading is done differently as explained in the last
email.
The other place is in notmuch-setup.c, but the notmuch setup does not
(for now) set hooks.path.
The command "notmuch config set" does not use notmuch_config_set for
some reason, but changes the key file directly.
- Erik
next prev parent reply other threads:[~2016-08-30 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 16:30 Feature request: Finer control of paths Erik Rybakken
2016-08-24 17:45 ` Jani Nikula
2016-08-24 21:55 ` [PATCH] Add option `hooks.path` for setting the directory of hooks Erik Rybakken
2016-08-26 10:57 ` David Bremner
2016-08-26 11:32 ` Tomi Ollila
2016-08-27 13:28 ` Erik Rybakken
2016-08-30 5:43 ` Tomi Ollila
2016-08-30 8:49 ` Erik Rybakken [this message]
2016-08-30 11:43 ` David Bremner
2016-08-30 13:35 ` Tomi Ollila
2016-08-30 17:51 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830084911.4gkpjpzca5jkkcwy@dell \
--to=erik.rybakken@math.ntnu.no \
--cc=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).