unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Stefano Zacchiroli <zack@upsilon.cc>
To: notmuch@notmuchmail.org
Subject: Re: Fwd: [PATCH] notmuch-mutt: deduce perl interpreter location from environment
Date: Thu, 21 Apr 2016 14:10:25 -0400	[thread overview]
Message-ID: <20160421181025.GB8684@upsilon.cc> (raw)
In-Reply-To: <CAL_dnaUZ3hEraomaJ3ysoNDWTiv_T+T61ut2NscaYyozMtx+gQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

On Thu, Apr 21, 2016 at 06:41:38PM +0100, Andreas Tolfsen wrote:
> The patch is straight forward.  You may want to just make the change
> yourself than jumping through the hoops of applying this.

Thanks Andreas for the suggestion; makes sense to me.

I just clarified in the commit message that, even if -w is dropped,
there is still use warnings in the script. New patch attached.

David: can you please push this to master?

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  zack@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader . . . . . @zacchiro . . . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »

[-- Attachment #2: 0001-notmuch-mutt-use-env-to-locate-perl-for-increased-po.patch --]
[-- Type: text/x-diff, Size: 815 bytes --]

From 3e27c59e6ab02fa652b35ce3a23e4d324ed69b6d Mon Sep 17 00:00:00 2001
From: Stefano Zacchiroli <zack@upsilon.cc>
Date: Thu, 21 Apr 2016 14:04:23 -0400
Subject: [PATCH] notmuch-mutt: use env to locate perl for increased
 portability

Note: this patch drops -w from the shebang line, but we still have
"use warnings" in the script, which is superior anyhow.

Thanks Andreas Tolfsen for the suggestion.
---
 contrib/notmuch-mutt/notmuch-mutt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt
index b47b365..97fb2d8 100755
--- a/contrib/notmuch-mutt/notmuch-mutt
+++ b/contrib/notmuch-mutt/notmuch-mutt
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
 #
 # notmuch-mutt - notmuch (of a) helper for Mutt
 #
-- 
2.8.0.rc3


  parent reply	other threads:[~2016-04-21 18:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1459019105-4513-1-git-send-email-ato@mozilla.com>
2016-04-21 13:30 ` [PATCH] notmuch-mutt: deduce perl interpreter location from environment Andreas Tolfsen
2016-04-21 13:42   ` Stefano Zacchiroli
2016-04-21 17:43     ` David Bremner
     [not found] ` <CAL_dnaUZ3hEraomaJ3ysoNDWTiv_T+T61ut2NscaYyozMtx+gQ@mail.gmail.com>
2016-04-21 18:10   ` Fwd: " Stefano Zacchiroli
2016-04-21 18:10   ` Stefano Zacchiroli [this message]
2016-04-30 11:37     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160421181025.GB8684@upsilon.cc \
    --to=zack@upsilon.cc \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).