[PATCH] notmuch.Database.remove_message should raise exception on failure

[PATCH] notmuch.Database.remove_message should raise exception on failure

[Daniel Kahn Gillmor]

The notmuch python bindings document that database.remove_message
should raise an exception when the message removal fails, but they
don't actually do it.
---
 bindings/python/notmuch/database.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py
index 93e7b7a..f304533 100644
--- a/bindings/python/notmuch/database.py
+++ b/bindings/python/notmuch/database.py
@@ -483,7 +483,10 @@ class Database(object):
                removed.
         """
         self._assert_db_is_initialized()
-        return self._remove_message(self._db, _str(filename))
+        status = self._remove_message(self._db, _str(filename))
+        if status not in [STATUS.SUCCESS, STATUS.DUPLICATE_MESSAGE_ID]:
+            raise NotmuchError(status)
+        return status
 
     def find_message(self, msgid):
         """Returns a :class:`Message` as identified by its message ID
-- 
2.7.0

Re: [PATCH] notmuch.Database.remove_message should raise exception on failure

[Justus Winter]

Quoting Daniel Kahn Gillmor (2016-02-10 17:53:46)
> The notmuch python bindings document that database.remove_message
> should raise an exception when the message removal fails, but they
> don't actually do it.

Merged, thanks!

Justus