unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Steven Allen <steven@stebalien.com>
To: notmuch@notmuchmail.org
Subject: [bug] notmuch doesn't commit changes before an open transaction on close
Date: Sun, 25 Oct 2015 17:02:15 -0400	[thread overview]
Message-ID: <20151025210215.GA3754@stebalien.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

Notmuch claims to commit changes made before an open transaction on
close but actually throws them away (according to the documentation).

According to the notmuch documentation,

> For writable databases, notmuch_database_close commits all changes
> to disk before closing the database.  If the caller is currently in
> an atomic section (there was a notmuch_database_begin_atomic
> without a matching notmuch_database_end_atomic), this will discard
> changes made in that atomic section (but still commit changes made
> prior to entering the atomic section).

However, this isn't true. Notmuch atomic transactions don't flush on
entry so, this comment from the xapian documentation applies:

> If you're applying atomic groups of changes and only wish to ensure
> that each group is either applied or not applied, then you can prevent
> the automatic commit() before and after the transaction by starting
> the transaction with begin_transaction(false). However, if
> cancel_transaction is called (or if commit_transaction isn't called
> before the WritableDatabase object is destroyed) then any changes
> which were pending before the transaction began will also be
> discarded.

source: http://xapian.org/docs/apidoc/html/classXapian_1_1WritableDatabase.html

This means that, in theory at least, xapian could throw away *all*
changes to the database if a transaction is open.

-- 
Steven Allen
(310) 433-5865
((Do Not Email <honeypot@stebalien.com>))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

             reply	other threads:[~2015-10-25 21:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-25 21:02 Steven Allen [this message]
2017-03-12  0:33 ` [bug] notmuch doesn't commit changes before an open transaction on close David Bremner
2021-12-26  0:13 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151025210215.GA3754@stebalien.com \
    --to=steven@stebalien.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).