From: Johannes Schauer <josch@debian.org>
To: Jani Nikula <jani@nikula.org>,
"David Bremner" <david@tethera.net>,
"David Bremner" <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [WIP] tests: add test for case insensitive Content-Disposition
Date: Sun, 18 Oct 2015 14:05:44 +0200 [thread overview]
Message-ID: <20151018120544.4280.70668@localhost> (raw)
In-Reply-To: <87r3kscrsm.fsf@nikula.org>
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
Hi,
Quoting Jani Nikula (2015-10-18 13:58:01)
> On Tue, 06 Oct 2015, David Bremner <david@tethera.net> wrote:
> > These broken now, but will be fixed in the next commit
> > ---
> >
> > The first test is OK, but the second one currently fails. It isn't
> > clear to me if content dispositions permit RFC2047 style
> > encoding. GMime does not decode them automatically (hence this test is
> > failing). What is true is that the RFC states "Unrecognized
> > disposition types should be treated as `attachment'". So maybe the
> > logic in patch 1 should be reversed to check != 'inline'.
>
> > +Content-Type: text/plain
> > +Content-Disposition: =?utf-8?b?YXR0YWNobWVudDsgZmlsZW5hbWU9ImJlZ3LDvMOfdW5n?=
> > + =?utf-8?b?LnBkZiI=?=
> > +Content-Description: this is a very exciting file
>
> Did you handcraft the example, or did some program actually produce
> this? I don't think this is [RFC 2231] compliant. IIUC only the content
> disposition parameter values may contain encoded words with
> charset/language specification. Like this,
>
> Content-Disposition: attachment; filename="=?utf-8?B?cMOkw6RtaWVz?="
I'm using alot as my MUA and that produced the Content-Disposition line I
quoted.
Thanks!
cheers, josch
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAABCAAGBQJWI4sYAAoJEPLLpcePvYPhjnsP/1yEawnlB7hExS9Bb8dUqOh7
paNeYjCUNAGko0z+Kt4YysWvK/T7McXr/U9t6osmeKoaRmiCijUTi/9yfXBu3to1
Ou28Fa/gUyfJbiMtE8JbTUfqB/dOSy2wY5RNfAqikU8NkhuNsAjhkncRautZ+YyY
HLJUigT6V5nVoN7FlGjJ1atalEqbn5kpZlnIIafQWW5M5cnHSWiL1n7lmBjWev/T
bQyDmKGN7JN6eyeyHbqvqIcNIPsGQd7sODUNW4ukUz9R1wVzNGBWqpXiI8+zCN3d
YXg1jMNEzGaAjYTcyFKYe74KD2E5tgDeXmII63B7cpsry6OJRHcQUD9I8CJWylC9
ZRuPk4YZy9s8CMtioTPoTq+w8siccSLB9Qcrr3pWWy1b4sNCDgnmSYQD9YJuGgkt
4pzYX3AaorN2ILEuWzN8tqb7iTQXfQLoLYSFoR6lrVO48BGBY7L8Wc+OJUkw+AeX
Czel0eD2mny6SxFw7NtRsDBo1Wwzp869YKd2X0MTVrUm9ZXlRfGcXAGQFBTQFPTn
WaYnSCY9bKpXoZldI9tJq6wIoPd54w6GYCbMLMEZisn4mFHVeOgGlwPUaYzsm86T
835AGm62l+26M50V4L6c3DTJ1D5O8sKsXSA9CakPypSGyGXOZAY8gNZX7Y+sof7Q
YcbmXyBxKNCFpTrkQW0h
=H93j
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-10-18 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150917070056.1941.94846@localhost>
[not found] ` <20150917083612.1941.22480@localhost>
2015-09-17 8:39 ` [bug] notmuch requires Content-Disposition mime header value to be lower case Johannes Schauer
2015-09-18 12:03 ` David Bremner
2015-09-18 12:37 ` Johannes Schauer
2015-09-18 13:26 ` David Bremner
2015-09-26 8:59 ` Jani Nikula
2015-09-26 9:35 ` [PATCH 1/2] lib: content disposition values are not case-sensitive Jani Nikula
2015-09-26 9:35 ` [PATCH 2/2] cli: " Jani Nikula
2015-10-06 10:20 ` [WIP] tests: add test for case insensitive Content-Disposition David Bremner
2015-10-18 11:58 ` Jani Nikula
2015-10-18 12:05 ` Johannes Schauer [this message]
2015-11-19 11:57 ` [PATCH 1/2] lib: content disposition values are not case-sensitive David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151018120544.4280.70668@localhost \
--to=josch@debian.org \
--cc=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).