From: Johannes Schauer <josch@debian.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [bug] notmuch requires Content-Disposition mime header value to be lower case
Date: Fri, 18 Sep 2015 14:37:24 +0200 [thread overview]
Message-ID: <20150918123724.1941.3900@localhost> (raw)
In-Reply-To: <87pp1grl2v.fsf@maritornes.cs.unb.ca>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
Hi,
Quoting David Bremner (2015-09-18 14:03:20)
> I'd recommend making your own new test, rather than modifying existing
> ones to test multiple things. I'd also recommend using json / sexp
> output for your tests, since the ad-hoc text format is kindof
> semi-deprecated.
can you take care of that? My goal was actually just to report this bug, not to
spend more time to develop a proper patch for it :)
Also, a related problem occurs when the Content-Disposition header contains
UTF8 characters, in which case the header value gets encoded. Apparently
notmuch does not attempt to decode it. Example mime header:
--===============7161366892858136962==
Content-Type: application/pdf
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: =?utf-8?b?YXR0YWNobWVudDsgZmlsZW5hbWU9ImJlZ3LDvMOfdW5n?=
=?utf-8?b?LnBkZiI=?=
Thanks!
cheers, josch
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAABCAAGBQJV/AWEAAoJEPLLpcePvYPhmIQQAKzQ2jHrlArH8TOK2Jc6Sj4a
u+bIlsRfYhvfFxp0dwXXUEh1zwSiEdvdPb9oMYavggMlZz3Yog+T2KBxQEvU+Q6j
Zc0ucb+TtuyzkmBMyijWuefsPVqMioHnyZdDxM7he3QCQBsJWQ9jOAXZ8BjEtmqA
ciISmXNUf9jtcAJh3ZIssAT+5V+oKlGIBFjXlZCekBOumlOH/L9ej/L02EsyOvNE
KTrdgtaWu/NnU0tbULgJxv7j8Via+0et5SJeaw0WsF9eYiuRVx99AnzhW2Wf6NhI
QYgCeNIQagr0RTzI/ufGDfZD4t+LHVD1IZQ4jlNCT2o7zPVCCFSMHOf1zOQDG6Hs
paOgfYSYNrPMUQYDnjqDElc7dV4viVzsMWIXw9YL/pW5sTtbfRX7+ZdM0OmXR4c7
lKx52dGYie+EQ2pU2GzOgJ+LEXMhbCl9w/jhEQdo5LsUdEL9MKS69V/RS1NpgMsP
ySzYl1FOhZzj38XrePKvO5wc5EFj5S7zXaTPkAXMAKhML2I4hShPmUkJQEr2zwt6
lcKqVA+005+oxppLXrMvUO4PflpZAaQcopi/XTQ2w/885Q7P1Bhhke4AwNpY59l3
0GGdg28giEX7cgq5AwzV4zia0lwt7+nH8MGgOSHsRhmdsJcEEj06nVsw+8E12lkA
rbTH+NWBLd0c+nWm0AYC
=tIQp
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-09-18 12:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150917070056.1941.94846@localhost>
[not found] ` <20150917083612.1941.22480@localhost>
2015-09-17 8:39 ` [bug] notmuch requires Content-Disposition mime header value to be lower case Johannes Schauer
2015-09-18 12:03 ` David Bremner
2015-09-18 12:37 ` Johannes Schauer [this message]
2015-09-18 13:26 ` David Bremner
2015-09-26 8:59 ` Jani Nikula
2015-09-26 9:35 ` [PATCH 1/2] lib: content disposition values are not case-sensitive Jani Nikula
2015-09-26 9:35 ` [PATCH 2/2] cli: " Jani Nikula
2015-10-06 10:20 ` [WIP] tests: add test for case insensitive Content-Disposition David Bremner
2015-10-18 11:58 ` Jani Nikula
2015-10-18 12:05 ` Johannes Schauer
2015-11-19 11:57 ` [PATCH 1/2] lib: content disposition values are not case-sensitive David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918123724.1941.3900@localhost \
--to=josch@debian.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).