unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Franz Fellner <alpine.art.de@gmail.com>
To: Ian Main <imain@stemwinder.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] VIM: Make an option to save sent mail locally
Date: Tue, 14 Oct 2014 15:45:35 +0200	[thread overview]
Message-ID: <20141014154535.GJ23373@TP_L520.localdomain> (raw)
In-Reply-To: <1412619036-29203-1-git-send-email-imain@stemwinder.org>

Why not simply use Notmuch::Database.add_message? Would save a
system-call.
One could easily copy the sent mail into nm_db_path/sent/cur, add it to the db, tag it.
Though I don't know enough about maildir handling, but probably rubys
Mail module could help here.

Another issue is configuration. Hardcoding "Sent" probably won't fit
everyones needs. And (if I understand DOCS correctly) db.add_message
doesn't even force you to keep sent mail folder inside db_path; correct
me if I'm wrong :) notmuch --insert will put it into folder relative to
db_path.

All in all the feature and the the rest of your work is very much
appreciated!

Franz

On Mon,  6 Oct 2014 11:10:36 -0700, Ian Main <imain@stemwinder.org> wrote:
> Add an option to use 'notmuch insert' to save your sent mail.
> ---
> 
> Add -inbox as well.
> 
>  vim/notmuch.vim | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/vim/notmuch.vim b/vim/notmuch.vim
> index 331e930..a9044c4 100644
> --- a/vim/notmuch.vim
> +++ b/vim/notmuch.vim
> @@ -58,6 +58,7 @@ let s:notmuch_date_format_default = '%d.%m.%y'
>  let s:notmuch_datetime_format_default = '%d.%m.%y %H:%M:%S'
>  let s:notmuch_reader_default = 'mutt -f %s'
>  let s:notmuch_sendmail_default = 'sendmail'
> +let s:notmuch_save_sent_locally_default = 1
>  let s:notmuch_folders_count_threads_default = 0
>  
>  function! s:new_file_buffer(type, fname)
> @@ -108,6 +109,18 @@ EOF
>  		echohl None
>  		return
>  	endif
> +
> +	if g:notmuch_save_sent_locally
> +		let out = system('cat ' . fname . ' | notmuch insert --create-folder --folder=Sent +sent -unread -inbox')
> +		let err = v:shell_error
> +		if err
> +			echohl Error
> +			echo 'Eeek! unable to save sent mail'
> +			echo out
> +			echohl None
> +			return
> +		endif
> +	endif
>  	call delete(fname)
>  	echo 'Mail sent successfully.'
>  	call s:kill_this_buffer()
> @@ -388,6 +401,10 @@ endfunction
>  "" root
>  
>  function! s:set_defaults()
> +	if !exists('g:notmuch_save_sent_locally')
> +		let g:notmuch_save_sent_locally = s:notmuch_save_sent_locally_default
> +	endif
> +
>  	if !exists('g:notmuch_date_format')
>  		if exists('g:notmuch_rb_date_format')
>  			let g:notmuch_date_format = g:notmuch_rb_date_format
> -- 
> 1.9.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2014-10-14 13:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-06 17:51 [PATCH] VIM: Make an option to save sent mail locally Ian Main
2014-10-06 18:10 ` Ian Main
2014-10-06 18:28   ` Tomi Ollila
2014-10-07  4:16     ` Ian Main
2014-10-19  9:53       ` Tomi Ollila
2014-10-14 13:45   ` Franz Fellner [this message]
2014-10-14 17:32     ` Ian Main
2014-10-18 20:27       ` Franz Fellner
2015-01-13  0:08       ` Bartosz Telenczuk
2015-01-21 19:05         ` Franz Fellner
2015-02-02 23:42           ` Bartosz Telenczuk
2015-02-05 10:34             ` Franz Fellner
2014-10-20 17:58 ` [PATCH v2] " Ian Main

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141014154535.GJ23373@TP_L520.localdomain \
    --to=alpine.art.de@gmail.com \
    --cc=imain@stemwinder.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).