From: Franz Fellner <alpine.art.de@gmail.com>
To: Ian Main <imain@stemwinder.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] VIM: Add URI handling
Date: Sat, 11 Oct 2014 14:29:43 +0200 [thread overview]
Message-ID: <20141011142943.GD23373@TP_L520.localdomain> (raw)
In-Reply-To: <543822f73d3fd_46ad163fe88cd@ovo.mains.priv.notmuch>
Here is a working implementation.
Please review carefully as I only can simulate ruby and vimscript
knowledge from what I see in notmuch.vim sourcefile and quick
googling.
Regards
Franz
diff --git a/plugin/notmuch.vim b/plugin/notmuch.vim
index 567f75c..ef9fefa 100644
--- a/plugin/notmuch.vim
+++ b/plugin/notmuch.vim
@@ -269,6 +269,14 @@ ruby << EOF
if uri.class == URI::MailTo
vim_puts("Composing new email to #{uri.to}.")
VIM::command("call s:compose('#{uri.to}')")
+ elsif uri.class == URI::MsgID
+ msg = $curbuf.message(uri.opaque)
+ if !msg
+ vim_puts("Message not found in NotMuch database: #{uri.to_s}")
+ else
+ vim_puts("Opening message #{msg.message_id} in thread #{msg.thread_id}.")
+ VIM::command("call s:show('thread:#{msg.thread_id}', '#{msg.message_id}')")
+ end
else
vim_puts("Opening #{uri.to_s}.")
cmd = VIM::evaluate('g:notmuch_open_uri')
@@ -429,11 +437,12 @@ endfunction
"" main
-function! s:show(thread_id)
+function! s:show(thread_id, msg_id)
call s:new_buffer('show')
setlocal modifiable
ruby << EOF
thread_id = VIM::evaluate('a:thread_id')
+ msg_id = VIM::evaluate('a:msg_id')
$cur_thread = thread_id
$messages.clear
$curbuf.render do |b|
@@ -465,6 +474,9 @@ ruby << EOF
end
b << ""
nm_m.end = b.count
+ if msg_id and nm_m.message_id == msg_id
+ VIM::command("normal #{nm_m.start}zt")
+ end
end
b.delete(b.count)
end
@@ -487,7 +499,7 @@ ruby << EOF
when 1; $cur_filter = nil
when 2; $cur_filter = $cur_search
end
- VIM::command("call s:show('#{id}')")
+ VIM::command("call s:show('#{id}', '')")
EOF
endfunction
@@ -917,6 +929,10 @@ ruby << EOF
q
end
+ def message(id)
+ @db.find_message(id)
+ end
+
def close
@queries.delete_if { |q| ! q.destroy! }
@db.close
@@ -937,12 +953,20 @@ ruby << EOF
end
end
+ module URI
+ class MsgID < Generic
+ end
+
+ @@schemes['ID'] = MsgID
+ end
+
class Message
attr_accessor :start, :body_start, :end
- attr_reader :message_id, :filename, :mail
+ attr_reader :message_id, :thread_id, :filename, :mail
def initialize(msg, mail)
@message_id = msg.message_id
+ @thread_id = msg.thread_id
@filename = msg.filename
@mail = mail
@start = 0
On Fri, 10 Oct 2014 11:18:31 -0700, Ian Main <imain@stemwinder.org> wrote:
> Franz Fellner wrote:
> > Works nice. Tested with an https and a mailto URI.
> > But it would be awesome if you could add message id handling, So one
> > could easily navigate to linked messages. I only found emacs client
> > implement this feature. What I read in the docs about ruby URI module
> > it should be fairly easy to add a custom scheme for id.
>
> I'm afraid I'm not sure what you mean by message id handling? It's
> probably something simple but .. :)
>
> Ian
next prev parent reply other threads:[~2014-10-11 12:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 20:23 [PATCH] VIM: Add URI handling Ian Main
2014-10-10 9:44 ` Franz Fellner
2014-10-10 18:18 ` Ian Main
2014-10-11 12:29 ` Franz Fellner [this message]
2014-10-15 19:33 ` Ian Main
2014-10-17 16:14 ` Franz Fellner
2014-10-20 17:45 ` Ian Main
2014-10-20 19:05 ` Tomi Ollila
2014-10-20 19:38 ` Franz Fellner
2014-10-21 14:25 ` Tomi Ollila
2014-10-20 18:53 ` Tomi Ollila
2014-10-23 22:19 ` [PATCH v2] " Ian Main
2014-10-24 9:52 ` Tomi Ollila
2014-10-24 16:11 ` [PATCH v3] " Ian Main
2014-10-24 16:30 ` Tomi Ollila
2014-10-24 17:03 ` Ian Main
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141011142943.GD23373@TP_L520.localdomain \
--to=alpine.art.de@gmail.com \
--cc=imain@stemwinder.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).