unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Franz Fellner <alpine.art.de@gmail.com>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH] VIM: Improve moving between messages in a thread
Date: Fri, 10 Oct 2014 11:21:22 +0200	[thread overview]
Message-ID: <20141010112122.GB28601@TP_L520.localdomain> (raw)
In-Reply-To: <1412618116-27586-1-git-send-email-imain@stemwinder.org>

Patch works fine for me. It also would be nice to have a "move to next
unread message" function.
Most beautiful would be a treeview of the thread structure. Currently
threads are rendered as plain list, so you can't immediately see and
jump to the quoted mail. Bower IMHO uses the best approach here. I tried
emacs treeview but did not really like it (partly because I failed badly
to implement a solution that shows treeview by default). Indent the
whole large Message view IMHO also is not a good (at least to me)
solution.

On Mon,  6 Oct 2014 10:55:16 -0700, Ian Main <imain@stemwinder.org> wrote:
> @@ -113,6 +114,22 @@ EOF
>  	call s:kill_this_buffer()
>  endfunction
>  
> +function! s:show_prev_msg()
> +ruby << EOF
> +	r, c = $curwin.cursor
> +	n = $curbuf.line_number
> +	i = $messages.index { |m| n >= m.start && n <= m.end }
> +	m = $messages[i - 1] if i > 0

This one
> +	vim_puts ("messages index is #{i} and m is #{m}")
was missed ;)

> +	if m
> +		r = m.body_start + 1
> +		scrolloff = VIM::evaluate("&scrolloff")
> +		VIM::command("normal #{m.start + scrolloff}zt")
> +		$curwin.cursor = r + scrolloff, c
> +	end
> +EOF
> +endfunction
> +
>  function! s:show_next_msg()
>  ruby << EOF
>  	r, c = $curwin.cursor
> @@ -121,8 +138,9 @@ ruby << EOF
>  	m = $messages[i + 1]
>  	if m
>  		r = m.body_start + 1
> -		VIM::command("normal #{m.start}zt")
> -		$curwin.cursor = r, c
> +		scrolloff = VIM::evaluate("&scrolloff")
> +		VIM::command("normal #{m.start + scrolloff}zt")
> +		$curwin.cursor = r + scrolloff, c
>  	end
>  EOF
>  endfunction
> -- 
> 1.9.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2014-10-10  9:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-06  7:12 [PATCH] Improve moving between messages in a thread Ian Main
2014-10-06 17:25 ` Ian Main
2014-10-06 17:55 ` [PATCH] VIM: " Ian Main
2014-10-10  9:21   ` Franz Fellner [this message]
2014-10-10 18:21     ` Ian Main
2014-10-18 20:30       ` Franz Fellner
2014-10-19  9:51         ` Tomi Ollila
2014-10-20 18:01   ` [PATCH v3] " Ian Main
2015-01-12 23:47     ` Bartosz Telenczuk
2015-01-21 18:53       ` Franz Fellner
2015-02-02 23:44         ` Bartosz Telenczuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141010112122.GB28601@TP_L520.localdomain \
    --to=alpine.art.de@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).