From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aclements@csail.mit.edu>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id EE8B4431FB6
	for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 16:30:02 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.3
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id C8gXqMJ-ltjL for <notmuch@notmuchmail.org>;
	Sun,  5 Oct 2014 16:29:57 -0700 (PDT)
Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149])
	by olra.theworths.org (Postfix) with ESMTP id 5BC1B431FAE
	for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 16:29:57 -0700 (PDT)
Received: from [104.131.20.129] (helo=awakeningjr)
	by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.72) (envelope-from <aclements@csail.mit.edu>)
	id 1XavFU-0000VZ-Vw; Sun, 05 Oct 2014 19:29:57 -0400
Received: from amthrax by awakeningjr with local (Exim 4.84)
	(envelope-from <aclements@csail.mit.edu>)
	id 1XavFU-0004fU-N1; Sun, 05 Oct 2014 19:29:56 -0400
Date: Sun, 5 Oct 2014 19:29:56 -0400
From: Austin Clements <aclements@csail.mit.edu>
To: David Bremner <david@tethera.net>
Subject: Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature
Message-ID: <20141005232956.GD7970@csail.mit.edu>
References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>
	<1412345958-8278-9-git-send-email-aclements@csail.mit.edu>
	<87d2a6q4hf.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87d2a6q4hf.fsf@maritornes.cs.unb.ca>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Oct 2014 23:30:03 -0000

Quoth David Bremner on Oct 05 at 10:56 am:
> Austin Clements <aclements@csail.mit.edu> writes:
> > +    if (new_features & NOTMUCH_FEATURE_GHOSTS) {
> > +	t_end = db->metadata_keys_end ("thread_id_");
> > +	for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t)
> > +	    ++total;
> > +    }
> 
> It would be nice to have the comment below, or something like it, for
> the loop above.

  /* The ghost message upgrade converts all thread_id_*
   * metadata values into ghost message documents. */
sound good?

> > +    /* Perform metadata upgrades. */
> > +
> > +    /* Prior to NOTMUCH_FEATURE_GHOSTS, thread IDs for missing
> > +     * messages were stored as database metadata. Change these to
> > +     * ghost messages.
> > +     */