From: "W. Trevor King" <wking@tremily.us>
To: Austin Clements <aclements@csail.mit.edu>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2] lib: Simplify close and codify aborting atomic section
Date: Wed, 24 Sep 2014 14:28:39 -0700 [thread overview]
Message-ID: <20140924212839.GE20130@odin.tremily.us> (raw)
In-Reply-To: <1411593623-8234-1-git-send-email-aclements@csail.mit.edu>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On Wed, Sep 24, 2014 at 05:20:23PM -0400, Austin Clements wrote:
> diff --git a/lib/notmuch.h b/lib/notmuch.h
> index fe2340b..5c40c67 100644
> --- a/lib/notmuch.h
> +++ b/lib/notmuch.h
> @@ -292,6 +292,11 @@ notmuch_database_open (const char *path,
> * notmuch_database_close can be called multiple times. Later calls
> * have no effect.
> *
> + * If the caller is currently in an atomic section (there was a
> + * notmuch_database_begin_atomic without a matching
> + * notmuch_database_end_atomic), this will abort the atomic section,
> + * discarding any modifications made in the atomic section.
> + *
> * Return value:
> *
> * NOTMUCH_STATUS_SUCCESS: Successfully closed the database.
Still no mention of “commit” or “if you're not in an atomic section”
;).
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-24 21:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 15:43 [PATCH] lib: Simplify close and codify aborting atomic section Austin Clements
2014-09-22 16:59 ` W. Trevor King
2014-09-22 18:50 ` Austin Clements
2014-09-22 19:00 ` W. Trevor King
2014-09-24 18:09 ` David Bremner
2014-09-24 18:18 ` W. Trevor King
2014-09-24 19:25 ` David Bremner
2014-09-24 19:44 ` W. Trevor King
2014-09-24 20:13 ` David Bremner
2014-09-24 20:29 ` W. Trevor King
2014-09-24 21:20 ` [PATCH v2] " Austin Clements
2014-09-24 21:28 ` W. Trevor King [this message]
2014-09-24 21:32 ` [PATCH v3] " Austin Clements
2014-09-24 21:39 ` W. Trevor King
2014-10-02 19:18 ` Austin Clements
2014-10-02 19:19 ` [PATCH v4] " Austin Clements
2014-10-02 19:41 ` W. Trevor King
2014-10-02 20:39 ` Austin Clements
2014-10-02 20:48 ` W. Trevor King
2014-10-03 8:48 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924212839.GE20130@odin.tremily.us \
--to=wking@tremily.us \
--cc=aclements@csail.mit.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).