[PATCH] python: Add binding for notmuch_query_add_tag_exclude

[PATCH] python: Add binding for notmuch_query_add_tag_exclude

[Thibaut Horel]

Implemented as the method `exclude_tag` of the class `Query`. This method takes
one argument, a string containing the name of the tag to exclude.
---
 NEWS                                  |  5 +++++
 bindings/python/docs/source/query.rst |  2 ++
 bindings/python/notmuch/query.py      | 15 +++++++++++++++
 3 files changed, 22 insertions(+)

diff --git a/NEWS b/NEWS
index f7aaedf..2d85090 100644
--- a/NEWS
+++ b/NEWS
@@ -22,6 +22,11 @@ from the config file.  Use something like:
       ...
     },
 
+Python Bindings
+---------------
+
+Add support for `notmuch_query_add_tag_exclude`
+
 Notmuch 0.18.1 (2014-06-25)
 ===========================
 
diff --git a/bindings/python/docs/source/query.rst b/bindings/python/docs/source/query.rst
index ddfc348..044b573 100644
--- a/bindings/python/docs/source/query.rst
+++ b/bindings/python/docs/source/query.rst
@@ -32,6 +32,8 @@
       :attr:`Query.SORT`) if explicitely specified via
       :meth:`set_sort`. By default it is set to `None`.
 
+   .. automethod:: exclude_tag
+
    .. automethod:: search_threads
 
    .. automethod:: search_messages
diff --git a/bindings/python/notmuch/query.py b/bindings/python/notmuch/query.py
index b11a399..94773ac 100644
--- a/bindings/python/notmuch/query.py
+++ b/bindings/python/notmuch/query.py
@@ -118,6 +118,21 @@ class Query(object):
         self.sort = sort
         self._set_sort(self._query, sort)
 
+    _exclude_tag = nmlib.notmuch_query_add_tag_exclude
+    _exclude_tag.argtypes = [NotmuchQueryP, c_char_p]
+    _exclude_tag.resttype = None
+
+    def exclude_tag(self, tagname):
+        """Add a tag that will be excluded from the query results by default.
+
+        This exclusion will be overridden if this tag appears explicitly in the
+        query.
+
+        :param tagname: Name of the tag to be excluded
+        """
+        self._assert_query_is_initialized()
+        self._exclude_tag(self._query, _str(tagname))
+
     """notmuch_query_search_threads"""
     _search_threads = nmlib.notmuch_query_search_threads
     _search_threads.argtypes = [NotmuchQueryP]
-- 
2.0.4

Re: [PATCH] python: Add binding for notmuch_query_add_tag_exclude

[David Bremner]

Thibaut Horel <thibaut.horel@gmail.com> writes:

> Implemented as the method `exclude_tag` of the class `Query`. This method takes
> one argument, a string containing the name of the tag to exclude

This tag looks pretty trivial.  I'll merge it unless I hear some
objections over the weekend.

d

Re: [PATCH] python: Add binding for notmuch_query_add_tag_exclude

[Justus Winter]

Quoting David Bremner (2014-09-20 07:15:02)
> Thibaut Horel <thibaut.horel@gmail.com> writes:
> 
> > Implemented as the method `exclude_tag` of the class `Query`. This method takes
> > one argument, a string containing the name of the tag to exclude
> 
> This tag looks pretty trivial.  I'll merge it unless I hear some
> objections over the weekend.

It looks fine indeed, thanks to the both of you.  The only tricky
thing I remember is the py2/py3 string/unicode thing, for which I seem
to have created the _str function, so it should be fine indeed.

Justus

Re: [PATCH] python: Add binding for notmuch_query_add_tag_exclude

[David Bremner]

Thibaut Horel <thibaut.horel@gmail.com> writes:

> Implemented as the method `exclude_tag` of the class `Query`. This
> method takes one argument, a string containing the name of the tag to
> exclude

pushed, thanks

d