From: Thomas Klausner <tk@giga.or.at>
To: David Bremner <david@tethera.net>
Cc: Notmuch list <notmuch@notmuchmail.org>
Subject: notmuch-0.18 issues [was Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem]
Date: Thu, 26 Jun 2014 15:08:26 +0200 [thread overview]
Message-ID: <20140626130826.GL11862@danbala.tuwien.ac.at> (raw)
In-Reply-To: <87a98zho9y.fsf@zancas.localnet>
[-- Attachment #1: Type: text/plain, Size: 2622 bytes --]
Hi David!
Thanks for getting back to me about this.
Currently configure (with some patches) says:
Checking for Xapian development files... Yes (1.2.17).
Checking for Xapian compaction support... Yes.
Checking for GMime development files... Yes (gmime-2.4 ).
Checking for Glib development files (>= 2.22)... Yes.
Checking for zlib (>= 1.2.5.2)... Yes.
Checking for talloc development files... Yes.
Checking for valgrind development files... No (but that's fine).
Checking for bash-completion (>= 1.90)... No (will not install bash completion).
Checking if emacs is available... emacs: not found
No (so will not byte-compile emacs code)
Checking if sphinx is available and supports nroff output... python: not found
No (falling back to rst2man).
Checking if rst2man is available... Yes.
Checking which platform we are on... Unknown.
*** Warning: Unknown platform. Notmuch might or might not build correctly.
Checking byte order... 1234
Checking for canonicalize_file_name... No (will use our own instead).
Checking for getline... Yes.
Checking for strcasestr... Yes.
Checking for strsep... Yes.
Checking for timegm... Yes.
Checking for dirent.d_type... Yes.
Checking for standard version of getpwuid_r... Yes.
Checking for standard version of asctime_r... Yes.
Checking for rpath support... Yes.
Checking for -Wl,--as-needed... Yes.
Checking for available C++ compiler warning flags...
-Wall -Wextra -Wwrite-strings
Checking for available C compiler warning flags...
-Wall -Wextra -Wwrite-strings -Wmissing-declarations
so this particular issue seems to be fixed, right?
I had some other issues with 0.18 though.
1. pkgsrc's copy of rst2man is called "rst2man.py". The configure test
for this fails, of course, and there is another place where rst2man is
called directly. I've changed that to rst2man.py locally, but it'd be
good if configure could test for both names, set a variable to the one
found, and use the variable in the other place.
2. doc/Makefile.local has "python" hardcoded. pkgsrc supports multiple
python versions at the same time, with the disadvantage that there is
no "python" executable, only "python2.6", "python2.7", "python3.3"
etc. I've passed in the proper executable name as PYTHONBIN and used
it in the Makefile.
3. installation of notmuch-version.el fails, because the install rule
has no dependency on the generated file notmuch-version.el. I've added
such a dependency.
The patches I used to make notmuch build are attached, but I can of
course test other patches if you prefer different solutions. I haven't
really run this version of notmuch yet.
Cheers,
Thomas
[-- Attachment #2: patch-doc_Makefile.local --]
[-- Type: text/plain, Size: 523 bytes --]
$NetBSD$
--- doc/Makefile.local.orig 2014-05-06 07:27:29.000000000 +0000
+++ doc/Makefile.local
@@ -7,8 +7,8 @@ SPHINXOPTS := -q
SPHINXBUILD = sphinx-build
DOCBUILDDIR := $(dir)/_build
-prerst2man := python $(srcdir)/$(dir)/prerst2man.py
-mkdocdeps := python $(srcdir)/$(dir)/mkdocdeps.py
+prerst2man := ${PYTHONBIN} $(srcdir)/$(dir)/prerst2man.py
+mkdocdeps := ${PYTHONBIN} $(srcdir)/$(dir)/mkdocdeps.py
# Internal variables.
ALLSPHINXOPTS := -d $(DOCBUILDDIR)/doctrees $(SPHINXOPTS) $(srcdir)/$(dir)
[-- Attachment #3: patch-doc_prerst2man.py --]
[-- Type: text/plain, Size: 346 bytes --]
$NetBSD$
--- doc/prerst2man.py.orig 2014-05-06 07:27:29.000000000 +0000
+++ doc/prerst2man.py
@@ -59,5 +59,5 @@ for page in man_pages:
outfile.write("".join(lines))
outfile.close()
- system('set -x; rst2man {0} {1}/{2}.{3}'
+ system('set -x; rst2man.py {0} {1}/{2}.{3}'
.format(filename, outdir, page[0], page[4]))
[-- Attachment #4: patch-emacs_Makefile.local --]
[-- Type: text/plain, Size: 357 bytes --]
$NetBSD$
--- emacs/Makefile.local.orig 2014-05-06 07:27:29.000000000 +0000
+++ emacs/Makefile.local
@@ -69,7 +69,7 @@ install: install-emacs
endif
.PHONY: install-emacs
-install-emacs:
+install-emacs: $(dir)/notmuch-version.el
mkdir -p "$(DESTDIR)$(emacslispdir)"
install -m0644 $(emacs_sources) "$(DESTDIR)$(emacslispdir)"
ifeq ($(HAVE_EMACS),1)
[-- Attachment #5: patch-configure --]
[-- Type: text/plain, Size: 365 bytes --]
$NetBSD: patch-aa,v 1.1 2014/01/09 12:15:23 wiz Exp $
--- configure.orig 2014-05-06 07:27:29.000000000 +0000
+++ configure
@@ -418,7 +418,7 @@ else
have_sphinx=0
printf "Checking if rst2man is available... "
- if rst2man -V > /dev/null 2>&1; then
+ if rst2man.py -V > /dev/null 2>&1; then
printf "Yes.\n"
have_rst2man=1
else
next prev parent reply other threads:[~2014-06-26 13:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 21:47 notmuch-0.16: realpath() compatibility issue; clang visibility problem Thomas Klausner
2014-01-04 12:35 ` Jani Nikula
2014-01-04 12:46 ` Jani Nikula
2014-01-04 12:53 ` Thomas Klausner
2014-01-04 13:06 ` Tomi Ollila
2014-01-04 13:28 ` Thomas Klausner
2014-01-04 12:52 ` Thomas Klausner
2014-01-04 13:18 ` David Bremner
2014-01-04 22:37 ` Thomas Klausner
2014-01-04 22:53 ` Jani Nikula
2014-04-08 11:26 ` David Bremner
[not found] ` <20140408123312.GZ5053@danbala.tuwien.ac.at>
2014-06-26 12:02 ` David Bremner
2014-06-26 12:52 ` David Bremner
2014-06-26 13:08 ` Thomas Klausner [this message]
2014-06-26 13:16 ` notmuch-0.18 issues [was Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem] Tomi Ollila
2014-06-26 15:00 ` David Bremner
2017-03-12 16:21 ` David Bremner
2017-03-12 17:24 ` Tomi Ollila
2017-03-12 20:52 ` Thomas Klausner
2017-03-12 16:00 ` notmuch-0.16: realpath() compatibility issue; clang visibility problem David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626130826.GL11862@danbala.tuwien.ac.at \
--to=tk@giga.or.at \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).