From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/5] emacs: hello: convert saved-searches to plists
Date: Sun, 6 Apr 2014 21:13:17 -0400 [thread overview]
Message-ID: <20140407011316.GJ15472@mit.edu> (raw)
In-Reply-To: <1396763089-32452-1-git-send-email-markwalters1009@gmail.com>
LGTM.
Quoth Mark Walters on Apr 06 at 6:44 am:
> This is v2 of the series; v1 is at
> id:1396733065-32602-1-git-send-email-markwalters1009@gmail.com
>
> I have made all the changes suggested by Austin in his review of v1. I
> include the diff from v1 below.
>
> There is now one slight oddity in the patch ordering: the
> documentation for the plist form appears in patch 3 while the users
> and references to that documentation appear in patch 2.
>
> Best wishes
>
> Mark
next prev parent reply other threads:[~2014-04-07 1:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 5:44 [PATCH v2 0/5] emacs: hello: convert saved-searches to plists Mark Walters
2014-04-06 5:44 ` [PATCH v2 1/5] emacs: hello: add helper functions for saved-searches Mark Walters
2014-04-06 5:44 ` [PATCH v2 2/5] emacs: hello: use the saved-search helper functions Mark Walters
2014-04-06 5:44 ` [PATCH v2 3/5] emacs: hello: add a customize for saved-searches Mark Walters
2014-04-06 5:44 ` [PATCH v2 4/5] emacs: hello: switch notmuch-hello-insert-buttons to plists Mark Walters
2014-04-06 5:44 ` [PATCH v2 5/5] emacs: Add a sort-order option to saved-searches Mark Walters
2014-04-07 1:13 ` Austin Clements [this message]
2014-04-09 17:09 ` [PATCH] News for emacs saved-searches change Mark Walters
2014-04-11 13:37 ` Tomi Ollila
2014-04-11 15:38 ` David Bremner
2014-04-11 13:41 ` David Bremner
2014-04-11 13:40 ` [PATCH v2 0/5] emacs: hello: convert saved-searches to plists David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407011316.GJ15472@mit.edu \
--to=amdragon@mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).