From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [Patch v4 0/8] emacs: show tag changes in buffer
Date: Sat, 22 Mar 2014 10:50:05 -0400 [thread overview]
Message-ID: <20140322145005.GF31187@mit.edu> (raw)
In-Reply-To: <1395489072-19001-1-git-send-email-markwalters1009@gmail.com>
LGTM. Ship it!
Quoth Mark Walters on Mar 22 at 11:51 am:
> This is v4 of this patch set. V3 is at
> id:1394597397-8486-1-git-send-email-markwalters1009@gmail.com. This
> addresses all the review comments from Austin.
>
> Patches 1-3 and 6-8 are unchanged. For patch 5 I have changed the
> comments slightly, tried to make the unread deleted case clearer by
> using the new `bare-tag' variable, and added all three custom format
> variables to the notmuch-faces group.
>
> For patch 6 I have switched to Austin's suggested approach with the
> changes mentioned in id:87pplek4v0.fsf@qmul.ac.uk and
> id:87mwgih2zx.fsf@qmul.ac.uk
>
> Best wishes
>
> Mark
next prev parent reply other threads:[~2014-03-22 14:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 11:51 [Patch v4 0/8] emacs: show tag changes in buffer Mark Walters
2014-03-22 11:51 ` [Patch v4 1/8] emacs: Combine notmuch-combine-face-text-property{, -string} Mark Walters
2014-03-22 11:51 ` [Patch v4 2/8] Make keys of notmuch-tag-formats regexps and use caching Mark Walters
2014-03-22 11:51 ` [Patch v4 3/8] emacs: tag split customise option for format-tags into a widget Mark Walters
2014-03-22 11:51 ` [Patch v4 4/8] emacs: tag: add customize for deleted/added tag formats Mark Walters
2014-03-22 11:51 ` [Patch v4 5/8] emacs: show: mark tags changed since buffer loaded Mark Walters
2014-03-22 11:51 ` [Patch v4 6/8] emacs: show: use orig-tags for tag display Mark Walters
2014-03-22 11:51 ` [Patch v4 7/8] emacs: search: use orig-tags in search Mark Walters
2014-03-22 11:51 ` [Patch v4 8/8] emacs: tree: " Mark Walters
2014-03-22 14:50 ` Austin Clements [this message]
2014-03-22 17:35 ` [Patch v4 0/8] emacs: show tag changes in buffer Jani Nikula
2014-03-25 0:10 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140322145005.GF31187@mit.edu \
--to=amdragon@mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).