From: "W. Trevor King" <wking@tremily.us>
To: Tomi Ollila <tomi.ollila@iki.fi>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub
Date: Tue, 18 Feb 2014 10:48:04 -0800 [thread overview]
Message-ID: <20140218184804.GW7538@odin.tremily.us> (raw)
In-Reply-To: <1392748492-29341-1-git-send-email-tomi.ollila@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
On Tue, Feb 18, 2014 at 08:34:52PM +0200, Tomi Ollila wrote:
> - def __values__(self):
> + def values(self):
Looks good to me. I'm not sure why I used __values__ in the first
place; probably just in the __ zone after __init__ and __setitem__.
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-18 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 18:34 [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub Tomi Ollila
2014-02-18 18:48 ` W. Trevor King [this message]
2014-02-22 1:21 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218184804.GW7538@odin.tremily.us \
--to=wking@tremily.us \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).