From: Peter Zijlstra <peterz@infradead.org>
To: Jani Nikula <jani@nikula.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch: Add "maildir:" search option
Date: Sun, 12 Jan 2014 17:06:19 +0100 [thread overview]
Message-ID: <20140112160619.GM7572@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <8761ppurfz.fsf@nikula.org>
On Sun, Jan 12, 2014 at 05:53:52PM +0200, Jani Nikula wrote:
> On Tue, 12 Nov 2013, Peter Zijlstra <peterz@infradead.org> wrote:
> > Subject: notmuch: Add "maildir:" search option
> >
> > The current "folder:" search terms are near useless when you have
> > recursive folders, introduce a boolean "maildir:" search term to
> > exactly match the maildir folder.
>
> Hi Peter -
>
> Per some discussion on IRC about the usefulness of the current "folder:"
> prefix, I went ahead and sent patches to make "folder:" a boolean prefix
> [1]. It's not the same as your "maildir:" implementation, but I believe
> you could use it to achieve the things you want with that. In
> particular, my proposed "folder:" prefix is the literal path from
> maildir root, and does not make any assumptions about maildir - i.e. it
> requires the final cur/new too. (That can be useful for some mutt users
> who need the cur/new distinction.)
>
> I am not opposed to adding another prefix like "maildir:" that does make
> assumptions on the mail storage and transformations on the path, but I
> do think it would be less important with the boolean "folder:" in place.
Right, sorry for disappearing; I failed to find time to finish the
patch.
I did actually modify it do loose the /new,/cur bits and I think I
addressed all other comments, including the file removal part.
Where I got 'stuck' was writing test cases.
Anyway, I'll try and have a look at the recent notmuch.git and see if it
does what I'd like it to.
Thanks for getting back to me.
~ Peter
next prev parent reply other threads:[~2014-01-12 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 15:56 [PATCH] notmuch: Add "maildir:" search option Peter Zijlstra
2013-11-12 19:31 ` Austin Clements
2013-11-12 19:39 ` Austin Clements
2013-11-13 20:08 ` Peter Zijlstra
2013-11-13 20:14 ` Peter Zijlstra
2013-11-12 19:47 ` Peter Zijlstra
2013-11-12 21:32 ` Jani Nikula
2014-01-12 15:53 ` Jani Nikula
2014-01-12 16:06 ` Peter Zijlstra [this message]
2014-01-12 17:05 ` Jani Nikula
2014-03-14 19:37 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140112160619.GM7572@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).