From: Peter Wang <novalazy@gmail.com>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] cli: add insert --must-index option
Date: Thu, 12 Sep 2013 00:13:49 +1000 [thread overview]
Message-ID: <20130912001349.GA18821@hili.localdomain> (raw)
In-Reply-To: <87hadtxfrr.fsf@qmul.ac.uk>
On Tue, 10 Sep 2013 09:06:00 +0100, Mark Walters <markwalters1009@gmail.com> wrote:
>
> Alternatively maybe add notmuch_database_destroy_with_flush or something
> which does give a return value. notmuch_database_close is only called 3
> times and notmuch_database_destroy lots of times so changing close is
> much less intrusive than changing destroy. But I don't know whether we
> would break any bindings or external programs etc.
>
> What do you think?
I think notmuch_database_close and notmuch_database_destroy should
return the status, and we update the three language bindings
and bump the soname.
Peter
next prev parent reply other threads:[~2013-09-11 14:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 0:07 [PATCH 1/3] cli: add insert --must-index option Peter Wang
2013-07-21 0:07 ` [PATCH 2/3] man: document insert --must-index Peter Wang
2013-07-21 0:07 ` [PATCH 3/3] test: test " Peter Wang
2013-07-21 8:31 ` [PATCH 1/3] cli: add insert --must-index option Mark Walters
2013-07-27 5:15 ` Peter Wang
2013-09-10 8:06 ` Mark Walters
2013-09-11 14:13 ` Peter Wang [this message]
2013-10-10 10:41 ` David Bremner
2013-10-10 12:30 ` Tomi Ollila
2013-10-10 14:15 ` David Bremner
2013-10-23 19:05 ` Tomi Ollila
2013-10-23 19:32 ` Austin Clements
2013-10-23 21:34 ` Tomi Ollila
2013-10-24 0:05 ` David Bremner
2013-10-24 10:19 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912001349.GA18821@hili.localdomain \
--to=novalazy@gmail.com \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).