[PATCH] emacs: distinguish tag `flagged' on terminal

[PATCH] emacs: distinguish tag `flagged' on terminal

[Gregor Zattler]

Change foreground color to `blue' like lines representing threads
with flagged messages in notmuch-search.  Before tag `flagged' was
shown in notmuch-show buffers as image star on graphical frames while
there was no visible distinction to other flags on terminal frames.
---
With this patch applied tag `unread' is now shown with foreground
`red' while tag `flagged' is shown in `blue'.  IMHO this should be
the other way around as flagged messages should be flagged more
prominently than mere unread ones.  

Sorry, did not find git-send-mail on my debian jessie box!?

 emacs/notmuch-tag.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
index 064cfa8..5c50ade 100644
--- a/emacs/notmuch-tag.el
+++ b/emacs/notmuch-tag.el
@@ -30,7 +30,8 @@
 
 (defcustom notmuch-tag-formats
   '(("unread" (propertize tag 'face '(:foreground "red")))
-    ("flagged" (notmuch-tag-format-image-data tag (notmuch-tag-star-icon))))
+    ("flagged" (propertize tag 'face '(:foreground "blue"))
+     (notmuch-tag-format-image-data tag (notmuch-tag-star-icon))))
   "Custom formats for individual tags.
 
 This gives a list that maps from tag names to lists of formatting
-- 
1.8.4.rc3

Re: [PATCH] emacs: distinguish tag `flagged' on terminal

[Tomi Ollila]

On Wed, Sep 04 2013, Gregor Zattler <telegraph@gmx.net> wrote:

> Change foreground color to `blue' like lines representing threads
> with flagged messages in notmuch-search.  Before tag `flagged' was
> shown in notmuch-show buffers as image star on graphical frames while
> there was no visible distinction to other flags on terminal frames.
> ---

This patch Looks Good ™ and works fine.

> With this patch applied tag `unread' is now shown with foreground
> `red' while tag `flagged' is shown in `blue'.  IMHO this should be
> the other way around as flagged messages should be flagged more
> prominently than mere unread ones.  

Probably so. I just (normally (*)) have 0 email with tag 'flagged' and many
with 'unread'. I've tried to go away re-tagging messages w/ unread but...
Anyway now I have 'flagged' with blue and other tags (sans unread) with
dark blue foreground ;D

(*) added 'flagged' tag to this message to test this feature.

> Sorry, did not find git-send-mail on my debian jessie box!?

Well, you managed to make perfectly good email out of it...
(without risks realized, that is :)

Tomi

>  emacs/notmuch-tag.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
> index 064cfa8..5c50ade 100644
> --- a/emacs/notmuch-tag.el
> +++ b/emacs/notmuch-tag.el
> @@ -30,7 +30,8 @@
>  
>  (defcustom notmuch-tag-formats
>    '(("unread" (propertize tag 'face '(:foreground "red")))
> -    ("flagged" (notmuch-tag-format-image-data tag (notmuch-tag-star-icon))))
> +    ("flagged" (propertize tag 'face '(:foreground "blue"))
> +     (notmuch-tag-format-image-data tag (notmuch-tag-star-icon))))
>    "Custom formats for individual tags.
>  
>  This gives a list that maps from tag names to lists of formatting
> -- 
> 1.8.4.rc3
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: distinguish tag `flagged' on terminal

[David Bremner]

Gregor Zattler <telegraph@gmx.net> writes:

> Change foreground color to `blue' like lines representing threads
> with flagged messages in notmuch-search.  Before tag `flagged' was
> shown in notmuch-show buffers as image star on graphical frames while
> there was no visible distinction to other flags on terminal frames.

pushed.

d